Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDK logging #22

Open
WillDaSilva opened this issue Sep 16, 2022 · 1 comment
Open

EDK logging #22

WillDaSilva opened this issue Sep 16, 2022 · 1 comment

Comments

@WillDaSilva
Copy link
Member

The EDK should provide plugins that use it with logging facilities.

An example of an issue that can arise without such facilities provided:

(cron-ext) will ~/meltano/cron-ext (main) $ meltano invoke cron
2022-09-16T19:21:11.159996Z [info     ] Environment 'dev' is active
Unable to list crontab entries.

The first log line is from Meltano. The second is from calling structlog.get_logger(APP_NAME).error.

The EDK should ensure that the plugins that use it emit logs that match the logging configuration the Meltano instance that is calling it. Maybe to do this the EDK should provide a get_logger function that provides an appropriately configured logger.

@WillDaSilva
Copy link
Member Author

There is the --meltano-log-json flag, and meltano.edk.logging.default_logging_config, but those seem to require a fair bit of boilerplate, and don't provide an out-of-the-box experience wherein the configuration inherits from the caller (Meltano).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant