Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Trying to append null for optional fields in JSON schema helpers should only warn, not crash the tap #1969

Closed
1 task
edgarrmondragon opened this issue Sep 18, 2023 · 0 comments · Fixed by #1970
Assignees
Labels
kind/Bug Something isn't working valuestream/SDK

Comments

@edgarrmondragon
Copy link
Collaborator

Singer SDK Version

0.31.1

Is this a regression?

  • Yes

Python Version

NA

Bug scope

Taps (catalog, state, etc.)

Operating System

NA

Description

A schema like

{
  "properties": {
    "an_int": {"type": "integer"},
    "an_object": {"type": "object"},
    "an_array": {"type": "array"},
    "a_null": {"type": "null"},
    "anything": {},
  }
}

is perfectly valid under the JSON schema spec, so it should be supported by this library.

However, this fails when processing anything as part of a PropertiesList schema helper because it can't append null to a non-existing type key.

Code

No response

@edgarrmondragon edgarrmondragon added kind/Bug Something isn't working valuestream/SDK labels Sep 18, 2023
@edgarrmondragon edgarrmondragon self-assigned this Sep 18, 2023
@edgarrmondragon edgarrmondragon changed the title bug: Trying to append null for optional fields in JSON schema helpers should only warn, not crash, the tap bug: Trying to append null for optional fields in JSON schema helpers should only warn, not crash the tap Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/Bug Something isn't working valuestream/SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant