-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle SIGTERM
messages to shut down gracefully
#129
Comments
This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the |
Still relevant |
This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the |
Handling I'm not sure the compute cost of SDK pipelines is a notable concern for anyone, but it'd be nice in any case. Helps with unexpected shutdowns in general. |
Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/130
Originally created by @aaronsteers on 2021-05-17 18:16:11
Summary
As brought up in this slack conversation, we have an opportunity to handle
SIGTERM
messages gracefully.Proposed benefits
This could improve SDK-based taps' functionality when being told to shut down gracefully.
Proposal details
SIGKILL
forces shutdown).Best reasons not to build
No downsides, no reason not to implement.
The text was updated successfully, but these errors were encountered: