Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail/warn when there are no selected streams #2779

Open
MeltyBot opened this issue Jan 31, 2022 · 6 comments · May be fixed by #2791
Open

Fail/warn when there are no selected streams #2779

MeltyBot opened this issue Jan 31, 2022 · 6 comments · May be fixed by #2791

Comments

@MeltyBot
Copy link
Contributor

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/3192

Originally created by @vischous on 2022-01-31 15:01:53


Hit something today similar to this, want to add / change this to

  • Fail when there are no selected streams

Use cases

  1. When starting a project if you forget to select any streams, you'll get a failure
  2. If you're using the select filter override and the tap you're using doesn't have that stream (ie no streams are selected) you'll fail, instead of succeeding with a 0 error code

Idea is similar to https://gitlab.com/meltano/meltano/-/issues/2861, but more for every day runs of meltano than just for configuring meltano.

@MeltyBot
Copy link
Contributor Author

@stale
Copy link

stale bot commented Apr 27, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Apr 27, 2023
@WillDaSilva
Copy link
Member

Still relevant

@stale stale bot removed the stale label May 8, 2023
Copy link

stale bot commented Nov 6, 2024

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Nov 6, 2024
@stale stale bot closed this as completed Nov 28, 2024
@edgarrmondragon edgarrmondragon transferred this issue from meltano/meltano Nov 28, 2024
@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented Nov 28, 2024

I think we can do this here rather than in Meltano, but it would be nice if we could eventually pair this with #1409.

For now, we could at least emit a warning when no stream is selected.

@edgarrmondragon edgarrmondragon changed the title Fail when there are no selected streams Fail/warn when there are no selected streams Nov 28, 2024
@edgarrmondragon edgarrmondragon added this to the v0.43 milestone Nov 28, 2024
@edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon modified the milestones: v0.43, v0.44 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants