MB-16524: Don't destroy configuation for allocation errors

We're returning the error condition up the stack

Change-Id: I66a27551f1e0a71b64b7e7dc51a469a0df177411
Reviewed-on: http://review.couchbase.org/56144
Tested-by: buildbot <[email protected]>
Reviewed-by: Jim Walker <[email protected]>

Author: trondn

vbucket/vbucket.c

@@ -169,7 +169,6 @@ static int populate_servers(struct vbucket_config_st *vb, cJSON *c) {
 
     vb->servers = calloc(vb->num_servers, sizeof(struct server_st));
     if (vb->servers == NULL) {
-        vbucket_config_destroy(vb);
         vb->errmsg = strdup("Failed to allocate servers array");
         return -1;
     }