Skip to content

Commit 6616b4e

Browse files
committed
A few more changes
1 parent 89724e3 commit 6616b4e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/mgclient.c

+2-1
Original file line numberDiff line numberDiff line change
@@ -390,6 +390,7 @@ static mg_map *build_hello_extra(const char *user_agent, const char *scheme,
390390
// by Memgraph) do not have such requirements:
391391
// https://neo4j.com/docs/bolt/current/bolt/message/#messages-hello
392392
// https://neo4j.com/docs/bolt/current/bolt/message/#messages-logon
393+
// NOTE: HELLO message does NOT contain schema after Bolt 5.0.
393394
if (scheme && strcmp(scheme, "basic") == 0) {
394395
assert(username && password);
395396
}
@@ -402,7 +403,7 @@ static mg_map *build_hello_extra(const char *user_agent, const char *scheme,
402403
return extra;
403404
}
404405

405-
mg_value *scheme_ = mg_value_make_string(scheme ? scheme : "basic");
406+
mg_value *scheme_ = mg_value_make_string(scheme ? scheme : "none"); // NOTE: Makes none default.
406407
if (!scheme_ || mg_map_insert_unsafe(extra, "scheme", scheme_) != 0) {
407408
goto cleanup;
408409
}

tests/client.cpp

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
#include <thread>
2020

2121
#include "mgclient.h"
22-
#include "mgcommon.h"
2322
#include "mgsession.h"
2423
#include "mgsocket.h"
2524

0 commit comments

Comments
 (0)