Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a good way of extracting/picking types from graphql-types #96

Open
Tracked by #108
GamerBene19 opened this issue Jul 21, 2022 · 0 comments
Open
Tracked by #108

Find a good way of extracting/picking types from graphql-types #96

GamerBene19 opened this issue Jul 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@GamerBene19
Copy link
Collaborator

Currently (e.g. in prices-n-tags branch) this approach is used:

type Props = {
  occurrence: GetOccurrencesByDateQuery['occurrencesByDate'][number];
};

While this certainly does work it would be cleaner if we would do sth like this:
some/where/types.ts

export type Occurrence = GetOccurrencesByDateQuery['occurrencesByDate'][number];

some/component.tsx

import { Occurrence } from `some/where/types`
...
type Props = {
  occurrence: Occurrenence;
};
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants