Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic merging support #186

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Basic merging support #186

wants to merge 3 commits into from

Conversation

GamerBene19
Copy link
Collaborator

No description provided.

@GamerBene19 GamerBene19 requested a review from a team January 30, 2023 20:14
@netlify
Copy link

netlify bot commented Jan 30, 2023 •
edited
Loading

✅ Deploy Preview for dev-mensatt ready!

Name Link
🔨 Latest commit 324d961
🔍 Latest deploy log https://app.netlify.com/sites/dev-mensatt/deploys/63d934c12724a0000873bad6
😎 Deploy Preview https://deploy-preview-186--dev-mensatt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

stormofice
stormofice approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@stormofice stormofice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great contribution!
I believe this will drastically improve the user experience and is an important step towards
better dish presentation.
Got some small questions, which are probably caused by my limited understanding of JS/TS

src/pages/admin/dishes/index.tsx Show resolved Hide resolved
src/pages/admin/dishes/index.tsx Show resolved Hide resolved
@GamerBene19 GamerBene19 added the blocked Cannot continue until dependencies are resolved label Jan 31, 2023
@GamerBene19
Copy link
Collaborator Author

Blocked until mergeDishes mutation is deployed on prod API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stormofice stormofice stormofice approved these changes

@StealWonders StealWonders StealWonders approved these changes

Assignees
No one assigned
Labels
blocked Cannot continue until dependencies are resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GamerBene19 @StealWonders @stormofice