From ab80538e77ac7d69f684160bb1b01b5c69285376 Mon Sep 17 00:00:00 2001
From: Vicente Eduardo Ferrer Garcia <vic798@gmail.com>
Date: Mon, 3 Feb 2025 22:38:15 +0100
Subject: [PATCH] Add base for supporting weak symbols on node loader.

---
 source/loaders/node_loader/CMakeLists.txt | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/source/loaders/node_loader/CMakeLists.txt b/source/loaders/node_loader/CMakeLists.txt
index d4af40596..5324ea73c 100644
--- a/source/loaders/node_loader/CMakeLists.txt
+++ b/source/loaders/node_loader/CMakeLists.txt
@@ -157,9 +157,6 @@ target_link_libraries(${target}
 	PRIVATE
 	${META_PROJECT_NAME}::metacall # MetaCall library
 
-	# TODO: Implement workaround to the problem: "PE32 file format does not support weak linkage"
-	# $<$<BOOL:${WIN32}>:${NodeJS_LIBRARY}> # NodeJS library
-
 	PUBLIC
 	${DEFAULT_LIBRARIES}
 
@@ -200,8 +197,10 @@ target_compile_options(${target}
 
 add_link_options(${target}
 	PRIVATE
-	# TODO: MacOS
-	# $<$<BOOL:${APPLE}>:-Wl,-undefined=dynamic_lookup>
+	$<$<CXX_COMPILER_ID:MSVC>:/IGNORE:4199>
+	$<$<CXX_COMPILER_ID:MSVC>:/DELAYLOAD:${NodeJS_LIBRARY_NAME}>
+	$<$<CXX_COMPILER_ID:MSVC>:/DELAYLOAD:${NodeJS_LIBRARY_NAME}>
+	$<$<AND:$<BOOL:${APPLE}>,$<CXX_COMPILER_ID:AppleClang,Clang>>:-undefined dynamic_lookup>
 
 	PUBLIC
 	${DEFAULT_LINKER_OPTIONS}