Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS Loader class is not implemented on ML example #132

Closed
JSMonk opened this issue May 10, 2021 · 2 comments
Closed

NodeJS Loader class is not implemented on ML example #132

JSMonk opened this issue May 10, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@JSMonk
Copy link

JSMonk commented May 10, 2021

🐛 Bug Report

I've tried to run the example with core 0.4.3 version and got the error with stack trace.

Expected Behavior

Run node.js without an error

Current Behavior

Throw the error like NodeJS Loader Error: NodeJS Loader class is not implemented

Possible Solution

Seems like it's related to the new API feature presented after HolyJS conference

Steps to Reproduce

  1. clone https://github.com/metacall/ml-news-article-scraper-example repo
  2. install all of the python and nodejs dependencies
  3. run metacall app.js

Context (Environment)

macOS Docker

@JSMonk JSMonk added the bug Something isn't working label May 10, 2021
viferga added a commit that referenced this issue May 10, 2021
@viferga
Copy link
Member

viferga commented May 14, 2021

This has been mitigated but the proper solution would be to implement class support in NodeJS.

@viferga
Copy link
Member

viferga commented Feb 3, 2023

This should be solved once this PR is merged: #343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants