You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ideal would be to unify both repos, and update the dependencies of those. For example node.dll repo binaries are being used in metacall/distributable-windows, we should update them once we unify the repos.
The text was updated successfully, but these errors were encountered:
hey @viferga, I would like to work on this.
From what I understand, libnode>index.js and node.dll>build.bat do the same thing.
index.js works for all OS, whereas build.bat works on Windows.
They clone the node js repository and then build it using vcbuild.bat for Windows and configure make for Linux and Mac.
For metacall/distributable-windows, we can change the build.bat file to point at libnode>releases instead of node.dll>releases.
Hey @PalashChitnavis , probably it will be enough to substitute it form metacall/distributable-windows. In any case we should check if all the tests pass, from the windows distributable to the metacall/install repo. Just in case.
I would also review the build arguments we use in build.bat just in case if they change in libnode index.js. As you can see, the old versions use a python patching script for enabling shared libraries, but I think this has been removed after 22.x or so, when they have started to think about shipping a new embedding API: nodejs/node#54660
In any case, I do not trust NodeJS at all, we should be careful with this kind of details.
We already implemented builds for node.dll: https://github.com/metacall/node.dll
The ideal would be to unify both repos, and update the dependencies of those. For example node.dll repo binaries are being used in
metacall/distributable-windows
, we should update them once we unify the repos.The text was updated successfully, but these errors were encountered: