Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify metacall/node.dll with this repository #7

Open
viferga opened this issue May 23, 2024 · 2 comments
Open

Unify metacall/node.dll with this repository #7

viferga opened this issue May 23, 2024 · 2 comments

Comments

@viferga
Copy link
Member

viferga commented May 23, 2024

We already implemented builds for node.dll: https://github.com/metacall/node.dll

The ideal would be to unify both repos, and update the dependencies of those. For example node.dll repo binaries are being used in metacall/distributable-windows, we should update them once we unify the repos.

@PalashChitnavis
Copy link

hey @viferga, I would like to work on this.
From what I understand, libnode>index.js and node.dll>build.bat do the same thing.
index.js works for all OS, whereas build.bat works on Windows.
They clone the node js repository and then build it using vcbuild.bat for Windows and configure make for Linux and Mac.

For metacall/distributable-windows, we can change the build.bat file to point at libnode>releases instead of node.dll>releases.

@viferga
Copy link
Member Author

viferga commented Feb 3, 2025

Hey @PalashChitnavis , probably it will be enough to substitute it form metacall/distributable-windows. In any case we should check if all the tests pass, from the windows distributable to the metacall/install repo. Just in case.

I would also review the build arguments we use in build.bat just in case if they change in libnode index.js. As you can see, the old versions use a python patching script for enabling shared libraries, but I think this has been removed after 22.x or so, when they have started to think about shipping a new embedding API: nodejs/node#54660

In any case, I do not trust NodeJS at all, we should be careful with this kind of details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants