Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reitit.ring.middleware.multipart requires spec-tools.core #355

Closed
MattiNieminen opened this issue Jan 30, 2020 · 1 comment · May be fixed by #371
Closed

reitit.ring.middleware.multipart requires spec-tools.core #355

MattiNieminen opened this issue Jan 30, 2020 · 1 comment · May be fixed by #371

Comments

@MattiNieminen
Copy link
Contributor

Current version of Reitit-middleware does not depend on spec-tools, but the implementation of reitit.ring.middleware.multipart requires it. The workaround for the user is not too bad (just require spec-tools in project).

However, since Spec is not a requirement for using Reitit and Spec-tools is used for internal implementation of Reitit-middleware, Spec-tools should probably be required by Reitit-middleware and not force the user to depend on it.
@MattiNieminen
Copy link
Contributor Author

Here's the PR: #356

@Deraen Deraen mentioned this issue Mar 5, 2020
Open
ikitommi added a commit that referenced this issue May 25, 2020
@ikitommi
Merge pull request #356 from MattiNieminen/bugfix/355-add-missing-dep…
9e42140 
…endency

Add missing spec-tools dependency to reitit-middleware. Fixes #355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename old reitit.ring.spec and move multipart specs to new ns metosin/reitit
1 participant
@MattiNieminen