Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retest all table checks with partitioned tables #467

Open
mfvanek opened this issue Oct 20, 2024 · 7 comments
Open

Retest all table checks with partitioned tables #467

mfvanek opened this issue Oct 20, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@mfvanek
Copy link
Owner

mfvanek commented Oct 20, 2024

See relkind
We need to make sure that the appropriate checks work for partitioned tables

@mfvanek mfvanek added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 20, 2024
@asharan2buff
Copy link

Hello!! I can take this up

@mfvanek
Copy link
Owner Author

mfvanek commented Oct 22, 2024

Hi @asharan2buff
I've assigned issue to you

@mfvanek mfvanek removed help wanted Extra attention is needed good first issue Good for newcomers labels Oct 22, 2024
@mfvanek
Copy link
Owner Author

mfvanek commented Oct 22, 2024

@asharan2buff please provide here sql queries to create a database for testing and then retest each query that retrieves information about tables

@asharan2buff
Copy link

@mfvanek could you expand a bit more on how to proceed. From what I understood so far, Do we need to add relkind ='p' check in all tests?

@mfvanek
Copy link
Owner Author

mfvanek commented Oct 24, 2024

Do we need to add relkind ='p' check in all tests?

No, we don't, not right now.

Sample scenario:

  1. Search for sql queries with relkind == 'r'
    https://github.com/search?q=repo%3Amfvanek%2Fpg-index-health-sql%20relkind%20&type=code

  2. For each found check prepare a test with partitioned table.
    See https://github.com/mfvanek/pg-index-health-demo/tree/master/db-migrations/src/main/resources/db/changelog/sql
    or tests in https://github.com/mfvanek/pg-index-health/tree/master/pg-index-health-core/src/testFixtures/java/io/github/mfvanek/pg/support/statements

  3. We need to figure out whether current implementation able to find problems with partitioned tables or not.

  4. After that we can discuss the results and further steps.

@asharan2buff
Copy link

Got it...

@mfvanek
Copy link
Owner Author

mfvanek commented Nov 26, 2024

@asharan2buff any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants