Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors during route preloading are not handled #112

Open
th0r opened this issue Dec 29, 2021 · 1 comment
Open

Errors during route preloading are not handled #112

th0r opened this issue Dec 29, 2021 · 1 comment

Comments

@th0r
Copy link

th0r commented Dec 29, 2021

The logic that initiates preloading of a lazy route doesn't handle potential load errors (e.g. bad network connection) so they are thrown. I think preloader should ignore them as they're not critical but we have to ensure they don't break the app and router will initiate loading of the failed module after user navigates to the corresponding route.

Here is the stacktrace of one of such errors:

sentry awsprod workato com_workato_workato-frontend_issues_497458_ (1)

@th0r th0r changed the title Error during route preloading is not handled Errors during route preloading are not handled Dec 29, 2021
@th0r
Copy link
Author

th0r commented Jan 24, 2022

@mgechev sorry, did you have time to take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant