Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git urls can't handle a version range #12

Open
elijahsmith opened this issue Apr 16, 2015 · 2 comments
Open

git urls can't handle a version range #12

elijahsmith opened this issue Apr 16, 2015 · 2 comments

Comments

@elijahsmith
Copy link

when specifying a git url for the package (or, probably but not tested, a custom package name) the version check fails if it is a range (eg ~0.0.1). This is because it's being validated with semver.valid() which is intended to validate a specific version string, not a range.

I would suggest that neither case should use semver.valid(), as it's an additional amount of validation that doesn't get applied to a "regular" version string.

@elijahsmith
Copy link
Author

(if you like the suggestion that special validation for git url / custom package versions, I'd be happy to submit a PR for that...)

@mgol
Copy link
Owner

mgol commented Apr 17, 2015

PR welcome. :) Be sure to add a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants