Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support hoisted node_modules #36

Open
kuceb opened this issue May 21, 2019 · 3 comments
Open

support hoisted node_modules #36

kuceb opened this issue May 21, 2019 · 3 comments

Comments

@kuceb
Copy link

kuceb commented May 21, 2019

right now it only searches the sibling node_modules folder, but it would be nice to search node_modules that may be hoisted up further in the tree, since node will be able to resolve them.

e.g.:

root
	package.json
	node_modules/
		a-module-dep
	packages/
		a-module
		package.json

this way I could use yarn workspaces, which hoists node_modules of subpackages in a monorepo

@Raag007
Copy link

Raag007 commented Dec 28, 2020

Hello Everyone,
Can we please get support for this.

We have packages structure like below:

Lerna-Repo
node_modules
package.json 
        package1
                package.json
                node_modules
        package2
                package.json
                node_modules

We are using lerna bootstrap --hoist
It will be so helpful if the tool search node_modules that are hoisted up to the root.

cc: @bkucera

Thank you in advance.

@mgol
Copy link
Owner

mgol commented Dec 29, 2020

I agree it’d be useful in some cases. But I don’t have time to do it myself at the moment; PRs (with tests) welcome.

@isoroka-plana
Copy link

Ran into the same issue with npm workspaces. Looks like I cannot adapt this package in my monorepo at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants