-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skip first run prompt cli flag #104
Add skip first run prompt cli flag #104
Conversation
could this be related? #90 |
Thanks! I'll look at the PR later today. That's strange with the build errors. I tried now on master with rustc 1.77.1 (7cf61ebde 2024-03-27) (on Fedora 40) and it worked fine. I'll try to update rustc and see if it fails after that. The failure of |
The tests work fine for me also on rustc 1.81.0 (eeb90cda1 2024-09-04) (although I get a couple of new warnings). |
I tried it on GitHub code space and had the same problems like I described |
Do you have suggestions on how to move forward? #90 seems to be environment dependent, as a test that should not be. On NixOS I'm able to build and run all tests. See https://github.com/timon-schelling/timonos/blob/7ed1566c035a98bcec317974698ff6f0060e70ae/overlays/tere/overlay.nix |
Hi, I checked your code and the PR looks good! Thanks for also including the tests. Could you please
I'll then make a new release over the weekend. The mysterious failling test is the same as #90 so we can leave that for the future. |
576dfab
to
b6f32d7
Compare
- Add a cli flag named `--skip-first-run-prompt` that disables the welcome message shown on the first launch of tere, which prompts the user to update their shell configuration for proper directory changing functionality. (Thanks to Timon Schelling, Github #104) - Update dependencies
- Add a cli flag named `--skip-first-run-prompt` that disables the welcome message shown on the first launch of tere, which prompts the user to update their shell configuration for proper directory changing functionality. (Thanks to Timon Schelling, Github #104) - Update dependencies (Originally released as 1.5.2, but this was inconsistent with semver)
Adds a
--skip-first-run-prompt
flag."Disables the welcome message shown on the first launch of tere, which prompts the user to update their shell configuration for proper directory changing functionality. Use this flag if you have already configured your shell or want to bypass the prompt for other reasons."
See timon-schelling@eba4049#comments for the discussion that lead up to this.
@mgunyho The first commit contains all feature relevant code.
In the second commit I've updated the textwarp dependency, otherwise I'm not able to build master or this pr. error on master:
After updating textwarp I get a failing test both on main plus the second commit and for this pr.
RUST_BACKTRACE=1 cargo test --no-fail-fast --locked
:I guess this could be a rustc version mismatch but I'm not sure. What rustc version are you building against? Is this test working on master for you?