Added fix for "When the text record on tag is longer than 259 bytes t… don#61

Michael Haberler · Michael Haberler · commit cdc2677c116f · 2023-12-20T20:33:19.000+01:00
from don@3286f72 crashes in NdefMessage without this fix
diff --git a/src/NdefMessage.cpp b/src/NdefMessage.cpp
@@ -38,16 +38,16 @@ NdefMessage::NdefMessage(const byte *data, const uint16_t numBytes)
         int typeLength = data[index];
 
         uint32_t payloadLength = 0;
+        index++;
         if (sr)
         {
-            index++;
             payloadLength = data[index];
         }
         else
         {
             payloadLength =
                 (static_cast<uint32_t>(data[index]) << 24) | (static_cast<uint32_t>(data[index + 1]) << 16) | (static_cast<uint32_t>(data[index + 2]) << 8) | static_cast<uint32_t>(data[index + 3]);
-            index += 4;
+            index += 3;
         }
 
         int idLength = 0;

Original file line number	Diff line number	Diff line change
`@@ -38,16 +38,16 @@ NdefMessage::NdefMessage(const byte *data, const uint16_t numBytes)`
`38`	`38`	`int typeLength = data[index];`
`39`	`39`
`40`	`40`	`uint32_t payloadLength = 0;`
	`41`	`+ index++;`
`41`	`42`	`if (sr)`
`42`	`43`	`{`
`43`		`- index++;`
`44`	`44`	`payloadLength = data[index];`
`45`	`45`	`}`
`46`	`46`	`else`
`47`	`47`	`{`
`48`	`48`	`payloadLength =`
`49`	`49`	`(static_cast<uint32_t>(data[index]) << 24) \| (static_cast<uint32_t>(data[index + 1]) << 16) \| (static_cast<uint32_t>(data[index + 2]) << 8) \| static_cast<uint32_t>(data[index + 3]);`
`50`		`- index += 4;`
	`50`	`+ index += 3;`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`int idLength = 0;`