Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how to pass on "count" (or "weight"?) #48

Open
mhvk opened this issue Dec 18, 2018 · 5 comments
Open

Decide how to pass on "count" (or "weight"?) #48

mhvk opened this issue Dec 18, 2018 · 5 comments

Comments

@mhvk
Copy link
Owner

mhvk commented Dec 18, 2018

We briefly had a BaseData subclass of ndarray with a count attribute (#44), but this was rather problematic, so for now we are using a structured dtype with 'data' and 'count' entries (#38). Should think if that is really what we want.

@mhvk
Copy link
Owner Author

mhvk commented Jun 4, 2019

While thinking about what to do with count in, e.g., dedispersion: possibly, it should just be a float so that it can be dedispersed. Indeed, it might make sense to more generally call it "weight".

@mhvk mhvk changed the title Decide how to pass on "count" Decide how to pass on "count" (or "weight"?) Jun 4, 2019
@luojing1211
Copy link
Collaborator

If we are going to use "The weight" as a data mask. Can we make something like a masked array?

@mhvk
Copy link
Owner Author

mhvk commented Jun 4, 2019

Can we make something like a masked array?

That would be a good solution. Ideally we implement something that can replace the data we have and "just work" for tasks like Dedispersion. Alternatively, we could add a 2-item dimension to the sample shape.

@luojing1211
Copy link
Collaborator

I am trying to picture how does out pipeline handle the mask/weight. The weight array flows with the pipeline. Another interesting question is should we include the weight to our output file, psrfits file.

@mhvk
Copy link
Owner Author

mhvk commented Jun 5, 2019

Yes, my hope was that by having a float weight, one could just "dedisperse" it, etc. Ideally, we do indeed have the weight in the output file too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants