Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better instruction set tests #39

Open
michaelcmartin opened this issue Jul 17, 2024 · 0 comments
Open

Better instruction set tests #39

michaelcmartin opened this issue Jul 17, 2024 · 0 comments

Comments

@michaelcmartin
Copy link
Owner

There are two issues with our current opcode/addressing mode unit tests:

  • The current tests use the conceit of having each opcode repeat its opcode as an operand, which isn't sufficient to test endianness of output on its own.
  • The unit tests are hand-generated instead of machine generated from the opcode specs.

gensets.py should get a companion script gentests.py to generate the test cases, and the test instructions' arguments should produce predictable bytes distinct from the opcodes themselves and from each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant