-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screen height on tablet vs keyboard #1162
Draft
microbit-grace
wants to merge
17
commits into
main
Choose a base branch
from
keyboard
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3628e62
Debug logging
microbit-grace 5848e9e
Set overflow as hidden
microbit-grace 55b5d3c
Use visual viewport css for Android
microbit-grace be63cca
Try using 100svh for height
microbit-grace a9759d6
Add resize content config in viewport
microbit-grace 2f49f26
Apply svh and fallback
microbit-grace acaa12b
Set 100svh for height for non-iOS
microbit-grace 43ccb90
Update comments
microbit-grace 86d25a2
Use full height of screen even when keyboard triggered
microbit-grace 70ba3ee
Add overflow hidden and 100% height
microbit-grace 640c5e4
Do not render simulator when collapsed
microbit-grace e6313d0
Use min height of sidebar as the workbench min height
microbit-grace 70e4dd6
Set min-width and min-height
microbit-grace 0800b1d
Remove visual viewport CSS variable component
microbit-grace bb77f91
Revert "Do not render simulator when collapsed"
microbit-grace 11886ee
Display simulator none when collapsed
microbit-grace 5ef82f8
Organise imports
microbit-grace File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not needed since we are aiming to have the keyboard overlay the UI instead of having a shifting action bar |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes some of the extra space around the UI that is added when the simulator is collapsed.
visibility: hidden
does not change the layout of the document,display: none
does.