Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add microblog_footer.html #7

Open
manton opened this issue Oct 13, 2023 · 0 comments
Open

Add microblog_footer.html #7

manton opened this issue Oct 13, 2023 · 0 comments

Comments

@manton
Copy link
Contributor

manton commented Oct 13, 2023

Adding this issue to put a couple thoughts down in one place. Similar to microblog_head.html, I think we do need a footer version to balance it. This would include the basic HTML that most themes need, like including custom_footer.html and the JS includes.

The reason this seems important to me now is I've been thinking about adding a footers field to plugin.json to include other HTML before the closing </body>. There's not currently a great way to do that unless you just need JS.

(I've also thought about a kind of replacements field that could replace arbitrary HTML tags, not just </body>… But that has performance tradeoffs that I don't think we want to deal with right now.)

We may or may not do this. Just don't want to forget. If we change our mind, I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant