Add environment (system/container) memory metrics #5308
Conversation
|
@fabcmartins Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@fabcmartins Thank you for signing the Contributor License Agreement! |
| public void bindTo(MeterRegistry registry) { | ||
| Runtime runtime = Runtime.getRuntime(); | ||
| if (committedVirtualMemorySize != null) { | ||
| Gauge.builder("system.virtualmemory.commited", operatingSystemBean, x -> invoke(committedVirtualMemorySize)) |
There was a problem hiding this comment.
Maybe split the words virtual and memory using virtual_memory for better readability?
There was a problem hiding this comment.
And I also think that this should be process.virtual_memory.committed. The javadoc on getCommittedVirtualMemorySize says Returns the amount of virtual memory that is guaranteed to be available to the running process.. So, maybe process namespace suits it better than system.
There was a problem hiding this comment.
I renamed the gauge.
I also noticed that other metrics are referenced by the class PrometheusSample should I add MemoryMetrics to it? What is its purpose?
Resolves 5234