Fix setting OTel span status on required situations #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GFriedrich
force-pushed
the
890-fix-status
branch
from
ad94ae3 to
0d7fe5b
Compare
GFriedrich
changed the title
jonatan-ivanov
force-pushed
the
890-fix-status
branch
2 times, most recently
from
794d9f9 to
b53253f
Compare
This will fix setting the OTel span status when: * the span ends and status is not yet set * the error state for a span is set Closes micrometer-metricsgh-890
jonatan-ivanov
force-pushed
the
890-fix-status
branch
from
d4a3da6 to
a0b3064
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix setting the OTel span status when:
Fixes #890