Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to document optimizations #96

Open
melix opened this issue Apr 7, 2022 · 2 comments
Open

Provide a way to document optimizations #96

melix opened this issue Apr 7, 2022 · 2 comments

Comments

@melix
Copy link
Collaborator

melix commented Apr 7, 2022

Feature description

Minimally, each optimization should be documented. Currently we have the @AOTModule which provides optimization metadata:

@AOTModule(
        id = NativeStaticServiceLoaderSourceGenerator.ID,
        description = AbstractStaticServiceLoaderSourceGenerator.DESCRIPTION,
        options = {
                @Option(
                        key = "service.types",
                        description = "The list of service types to be scanned (comma separated)",
                        sampleValue = AbstractStaticServiceLoaderSourceGenerator.DEFAULT_SERVICE_TYPES
                ),
                @Option(
                        key = "serviceloading.rejected.impls",
                        description = "A list of implementation types which shouldn't be included in the final application (comma separated)",
                        sampleValue = "com.Misc,org.Bar"
                ),
                @Option(
                        key = "serviceloading.force.include.impls",
                        description = "A list of implementation types to include even if they don't match bean requirements (comma separated)",
                        sampleValue = "com.Misc,org.Bar"
                ),
                @Option(
                        key = Environments.POSSIBLE_ENVIRONMENTS_NAMES,
                        description = Environments.POSSIBLE_ENVIRONMENTS_DESCRIPTION,
                        sampleValue = Environments.POSSIBLE_ENVIRONMENTS_SAMPLE
                )
        },
        enabledOn = Runtime.NATIVE,
        subgenerators = {YamlPropertySourceGenerator.class}
)

This provides samples which are used by the sample generation task. But ideally, we should also provide some documentation which could be used by a documentation generator, similarly to what is done with configuration properties in Micronaut Core.

@alvarosanchez
Copy link
Member

Can they be documented manually first until we get there?

@melix
Copy link
Collaborator Author

melix commented Apr 7, 2022

Yes, that was the intent of my first sentence :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants