Hybrid Free Busy Configuration Checker #1934

MarcoLFrancisco · 2024-01-09T15:40:54Z

Issue:
Collect Exchange Hybrid Free Configuration Information in Exchange deployments is often time consuming and a big effort

Reason:
This script is aimed to assist in collecting Hybrid Free busy configuration information, both for OAuth and DAuth and both from On Premise and Exchange online side. It provides also information for what would be expected for each component reviewed and can assist our customer and our support engineers.

Fix:
Script collects relevant information as described in Microsoft Internal Documentation. Script does not produce changes on customer side other than generating txt and html Output

Validation:
Utilized on several occasions both on lab environments and with active support cases. It has proven to be useful.

dpaulson45

Started to review the script. there are a few changes that need to be made before we can merge and release this script. Please address the current comments, then will do another review.

dpaulson45 · 2024-01-09T15:52:49Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+#>
+#region Properties and Parameters
+
+[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseDeclaredVarsMoreThanAssignments', '', Justification = 'Variables are being used')]


You have a single script file, this shouldn't be here.

However, you do have a lot of lines in this file. This should be broken up into multiple files.

Divided into multiple files now.

Let's remove this, this should only be used for parameters that are never used in the initial script file. Which all of them appear to be. Then it is just a matter of addressing the other problems below.

dpaulson45 · 2024-01-09T15:53:08Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+
+Required Permissions:
+    - Organization Management
+    - Domain Admins (only necessary for the DCCoreRatio parameter)


DCCoreRatio isn't a parameter

@MarcoLFrancisco it appears you haven't committed the changes and pushed to your branch.

I think I missed the push. Now commited and pushed.

dpaulson45 · 2024-01-09T15:55:33Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+}
+#DisConnect-ExchangeOnline -Confirm:$False
+
+[System.Console]::Clear()


We shouldn't clear the console in our scripts.

dpaulson45 · 2024-01-09T15:56:29Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+    exit
+}
+
+Add-PSSnapin microsoft.exchange.management.powershell.Snapin


Unsupported way to load Exchange On Prem cmdlets.

Removed, not necessary if using Exchange Shell

dpaulson45 · 2024-01-09T15:58:24Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+if ($Help) {
+    Write-Host $bar
+    ShowHelp
+    $bar


$bar isn't defined yet, so it wouldn't show up.

$bar nor rlevant as we have included function to include line separation

dpaulson45 · 2024-01-09T16:03:50Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+function UserOnlineCheck {
+    Write-Host -ForegroundColor Green "Online Mailbox: $UserOnline"
+    Write-Host "Press the Enter key if OK or type an Exchange Online Email address and press the Enter key"
+    $UserOnlineCheck = [System.Console]::ReadLine()


No read lines, everything should be a parameter if we want user input or a should process function.

We will remove all console inputs. And only include parameters on script call.

Could we use Readkey?
Example:

Removed all ReadLine() and ReadKey()

dpaulson45 · 2024-01-09T16:04:54Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+    Write-Host -ForegroundColor White " Exchange Online Mailbox:"
+    Write-Host -ForegroundColor Green "  $UserOnline"
+
+    $script:html = "<!DOCTYPE html>


This should likely be its own file.

Html output now in its own file

dpaulson45 · 2024-01-09T16:07:04Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+    Write-Host -ForegroundColor Green " Get-OrganizationRelationship  | Where{($_.DomainNames -like $ExchangeOnlineDomain )} | Select Identity,DomainNames,FreeBusy*,TarGet*,Enabled, ArchiveAccessEnabled"
+    Write-Host $bar
+
+    $OrgRel


This variable is set somewhere else, should be either passed to this function by a parameter or set within this function.

We now pass as parameter

dpaulson45 · 2024-01-09T16:07:50Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+#region DAuth Functions
+
+function OrgRelCheck {
+    Write-Host $bar


Should make this $bar a function really to do this line.

Changed to be a funtion setting separator line

dpaulson45 · 2024-01-09T16:18:02Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+        $tdFBAccessLevel = "FreeBusyAccessLevel is set to AvailabilityOnly"
+        $tdFBAccessLevelColor = "green"
+    }
+    if ($OrgRel.FreeBusyAccessLevel -like "LimitedDetails" ) {
+        Write-Host -ForegroundColor Green "  FreeBusyAccessLevel is set to LimitedDetails"
+        $tdFBAccessLevel = "FreeBusyAccessLevel is set to  LimitedDetails"
+        $tdFBAccessLevelColor = "green"
+    }
+    if ($OrgRel.FreeBusyAccessLevel -ne "LimitedDetails" -AND $OrgRel.FreeBusyAccessLevel -ne "AvailabilityOnly" ) {
+        Write-Host -ForegroundColor Red "  FreeBusyAccessEnabled : False"
+        $tdFBAccessLevel = "FreeBusyAccessEnabled : False"
+        $tdFBAccessLevelColor = "Red"
+        $countOrgRelIssues++
+    }
+    #TarGetApplicationUri
+    Write-Host -ForegroundColor White   " TarGetApplicationUri:"
+    if ($OrgRel.TarGetApplicationUri -like "Outlook.com" ) {
+        Write-Host -ForegroundColor Green "  TarGetApplicationUri is Outlook.com"
+        $tdTarGetApplicationUri = "TarGetApplicationUri is Outlook.com"
+        $tdTarGetApplicationUriColor = "green"
+    } else {
+        Write-Host -ForegroundColor Red "  TarGetApplicationUri should be Outlook.com"
+        $tdTarGetApplicationUri = "TarGetApplicationUri should be Outlook.com"
+        $tdTarGetApplicationUriColor = "red"
+        $countOrgRelIssues++
+    }
+    #TarGetOwAUrl
+    Write-Host -ForegroundColor White   " TarGetOwAUrl:"
+    if ($OrgRel.TarGetOwAUrl -like "https://outlook.com/owa/$ExchangeOnlineDomain" -or $OrgRel.TarGetOwAUrl -like $Null) {
+        if ($OrgRel.TarGetOwAUrl -like "http://outlook.com/owa/$ExchangeOnlineDomain") {
+            Write-Host -ForegroundColor Green "  TarGetOwAUrl is http://outlook.com/owa/$ExchangeOnlineDomain. This is a possible standard value. TarGetOwAUrl can also be configured to be Blank."
+            $tdOrgRelTarGetOwAUrl = " $($OrgRel.TarGetOwAUrl) - TarGetOwAUrl is http://outlook.com/owa/$ExchangeOnlineDomain. This is a possible standard value. TarGetOwAUrl can also be configured to be Blank."
+            $tdOrgRelTarGetOwAUrlColor = "green"
+        }
+        if ($OrgRel.TarGetOwAUrl -like "https://outlook.office.com/mail") {
+            Write-Host -ForegroundColor Green "  TarGetOwAUrl is https://outlook.office.com/mail. This is a possible standard value. TarGetOwAUrl can also be configured to be Blank or http://outlook.com/owa/$ExchangeOnlineDomain."
+            $tdOrgRelTarGetOwAUrl = " $($OrgRel.TarGetOwAUrl) - TarGetOwAUrl is https://outlook.office.com/mail. TarGetOwAUrl can also be configured to be Blank or http://outlook.com/owa/$ExchangeOnlineDomain."
+            $tdOrgRelTarGetOwAUrlColor = "green"
+        }
+        if ($OrgRel.TarGetOwAUrl -like $Null) {
+            Write-Host -ForegroundColor Green "  TarGetOwAUrl is Blank, this is a standard value. "
+            Write-Host  "  TarGetOwAUrl can also be configured to be https://outlook.com/owa/$ExchangeOnlineDomain or https://outlook.office.com/mail"
+            $tdOrgRelTarGetOwAUrl = "$($OrgRel.TarGetOwAUrl) . TarGetOwAUrl is Blank, this is a standard value. TarGetOwAUrl can also be configured to be http://outlook.com/owa/$ExchangeOnlineDomain or http://outlook.office.com/mail. "
+            $tdOrgRelTarGetOwAUrlColor = "green"
+            if ($OrgRel.TarGetOwAUrl -like "https://outlook.com/owa/$ExchangeOnlineDomain") {
+                Write-Host -ForegroundColor Green "  TarGetOwAUrl is https://outlook.com/owa/$ExchangeOnlineDomain. This is a possible standard value. TarGetOwAUrl can also be configured to be Blank or http://outlook.office.com/mail."
+                $tdOrgRelTarGetOwAUrl = " $($OrgRel.TarGetOwAUrl) - TarGetOwAUrl is https://outlook.com/owa/$ExchangeOnlineDomain. This is a possible standard value. TarGetOwAUrl can also be configured to be Blank or http://outlook.office.com/mail."
+                $tdOrgRelTarGetOwAUrlColor = "green"
+            }
+        }
+    } else {
+        Write-Host -ForegroundColor Red "  TarGetOwAUrl seems not to be Blank or https://outlook.com/owa/$ExchangeOnlineDomain. These are the standard values."
+        $countOrgRelIssues++
+        $tdOrgRelTarGetOwAUrl = "  TarGetOwAUrl seems not to be Blank or https://outlook.com/owa/$ExchangeOnlineDomain. These are the standard values."
+        $tdOrgRelTarGetOwAUrlColor = "red"
+    }
+    #TarGetSharingEpr
+    Write-Host -ForegroundColor White   " TarGetSharingEpr:"
+    if ([string]::IsNullOrWhitespace($OrgRel.TarGetSharingEpr) -or $OrgRel.TarGetSharingEpr -eq "https://outlook.office365.com/EWS/Exchange.asmx ") {
+        Write-Host -ForegroundColor Green "  TarGetSharingEpr is ideally blank. This is the standard Value. "
+        Write-Host  "  If it is set, it should be Office 365 EWS endpoint. Example: https://outlook.office365.com/EWS/Exchange.asmx "
+        $tdTarGetSharingEpr = "  TarGetSharingEpr is ideally blank. This is the standard Value.
+        If it is set, it should be Office 365 EWS endpoint. Example: https://outlook.office365.com/EWS/Exchange.asmx "
+        $tdTarGetSharingEprColor = "green"
+    } else {
+        Write-Host -ForegroundColor Red "  TarGetSharingEpr should be blank or  https://outlook.office365.com/EWS/Exchange.asmx"
+        Write-Host  "  If it is set, it should be Office 365 EWS endpoint.  Example: https://outlook.office365.com/EWS/Exchange.asmx "
+        $tdTarGetSharingEpr = "  TarGetSharingEpr should be blank or  https://outlook.office365.com/EWS/Exchange.asmx
+        If it is set, it should be Office 365 EWS endpoint.  Example: https://outlook.office365.com/EWS/Exchange.asmx "
+        $tdTarGetSharingEprColor = "red"
+        $countOrgRelIssues++
+    }
+    #FreeBusyAccessScope
+    Write-Host -ForegroundColor White  " FreeBusyAccessScope:"
+    if ([string]::IsNullOrWhitespace($OrgRel.FreeBusyAccessScope)) {
+        Write-Host -ForegroundColor Green "  FreeBusyAccessScope is blank, this is the standard Value. "
+        $tdFreeBusyAccessScope = " FreeBusyAccessScope is blank, this is the standard Value."
+        $tdFreeBusyAccessScopeColor = "green"
+    } else {
+        Write-Host -ForegroundColor Red "  FreeBusyAccessScope is should be Blank, that is the standard Value."
+        $tdFreeBusyAccessScope = " FreeBusyAccessScope is should be Blank, that is the standard Value."
+        $tdFreeBusyAccessScopeColor = "red"
+        $countOrgRelIssues++
+    }
+    #TarGetAutoDiscoverEpr:
+    $OrgRelTarGetAutoDiscoverEpr = $OrgRel.TarGetAutoDiscoverEpr
+    if ([string]::IsNullOrWhitespace($OrgRelTarGetAutoDiscoverEpr)) {
+        $OrgRelTarGetAutoDiscoverEpr = "Blank"
+    }
+    Write-Host -ForegroundColor White   " TarGetAutoDiscoverEpr:"
+    if ($OrgRel.TarGetAutoDiscoverEpr -like "https://AutoDiscover-s.outlook.com/AutoDiscover/AutoDiscover.svc/WSSecurity" ) {
+        Write-Host -ForegroundColor Green "  TarGetAutoDiscoverEpr is correct"
+        $tdTarGetAutoDiscoverEPR = " TarGetAutoDiscoverEpr is https://AutoDiscover-s.outlook.com/AutoDiscover/AutoDiscover.svc/WSSecurity"
+        $tdTarGetAutoDiscoverEPRColor = "green"
+    } else {
+        Write-Host -ForegroundColor Red "  TarGetAutoDiscoverEpr is not correct. Should be https://AutoDiscover-s.outlook.com/AutoDiscover/AutoDiscover.svc/WSSecurity"
+        $tdTarGetAutoDiscoverEPR = " TarGetAutoDiscoverEpr is $OrgRelTarGetAutoDiscoverEpr . Should be https://AutoDiscover-s.outlook.com/AutoDiscover/AutoDiscover.svc/WSSecurity"
+        $tdTarGetAutoDiscoverEPRColor = "Red"
+        $countOrgRelIssues++
+    }


This code should be reduced. You have a lot of repeated strings creating new variables for different settings. Try adding values you want to a list and using that list. Each entry in the list contains the Name, Value, and Color in the form the object.

We are now using list. If aproved we can implement for other functions.

dpaulson45 · 2024-03-20T13:58:33Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+
+    if (-not $OnPremEWSUrl) {
+
+        $EWSVirtualDirectory = Get-WebServicesVirtualDirectory -server $Server -ErrorAction SilentlyContinue


Need to verify that we are running from an Exchange Server first before we just assume that is what we are doing.

Added function to check if Exchange Server

Also added $Server Output to screen

dpaulson45 · 2024-03-20T14:01:37Z

Diagnostics/FreeBusyChecker/Functions/hostOutput.ps1

+[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseDeclaredVarsMoreThanAssignments', '', Justification = 'Variables are being used in functions')]
+[CmdletBinding()]
+param (
+    [Parameter(Mandatory = $false)]
+    $TestingDAuthConfiguration = "---------------------------------------Testing DAuth Configuration-----------------------------------------------",
+    $TestingOAuthConfiguration = " ---------------------------------------Testing OAuth Configuration----------------------------------------------- ",
+    $CollectingExoAvailabilityInformation = " Collecting Exchange Online Availability Information",
+    $ExchangeOnlinePowershellModuleMessage = "`n Exchange Online Powershell Module is required to Check Free Busy Configuration on Exchange Online side. Installing Module",
+    $ExchangeOnlineModuleAvailableMessage = "`n ExchangeOnlineManagement module is available.",
+    $TestingExoDAuthConfiguration = " ---------------------------------------Testing DAuth Configuration----------------------------------------------- ",
+    $TestingExoOAuthConfiguration = " ---------------------------------------Testing OAuth Configuration----------------------------------------------- ",
+    $ThatIsAllForTheExchangeOnlineSide = " That is all for the Exchange Online Side"
+)


Not sure what is going on here. We started a new file and started it off like a completely new script with [CmdletBinding()] on the top with param This should only need to be done for the main script and new Function(s)

Mistake, removed

dpaulson45 · 2024-03-20T14:03:58Z

Diagnostics/FreeBusyChecker/Functions/OnPremOAuthFunctions.ps1

+[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseDeclaredVarsMoreThanAssignments', '', Justification = 'Variables are being used in functions')]
+[CmdletBinding()]
+param (
+    [Parameter(Mandatory = $false)]
+    [String] $tdIntraOrgTarGetAddressDomain
+)


Again, we shouldn't be having this type of a start of a file that we are just importing into a different main script.

Mistake, removed

dpaulson45 · 2024-03-20T14:04:09Z

Diagnostics/FreeBusyChecker/Functions/OnPremDAuthFunctions.ps1

+[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseDeclaredVarsMoreThanAssignments', '', Justification = 'Variables are being used in functions')]
+[CmdletBinding()]
+param (
+    [Parameter(Mandatory = $false)]
+    [String] $OrgRelTarGetAutoDiscoverEpr
+)


Again, we shouldn't be having this type of a start of a file that we are just importing into a different main script.

Mistake, removed

dpaulson45 · 2024-03-20T14:04:18Z

Diagnostics/FreeBusyChecker/Functions/ExoOauthFunctions.ps1

+[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseDeclaredVarsMoreThanAssignments', '', Justification = 'Variables are being used in functions')]
+[CmdletBinding()]
+param (
+    [Parameter(Mandatory = $false)]
+    [String] $tdEXOIntraOrgConTarGetAddressDomains
+)


Again, we shouldn't be having this type of a start of a file that we are just importing into a different main script.

Mistake, removed

dpaulson45 · 2024-03-20T14:04:29Z

Diagnostics/FreeBusyChecker/Functions/ExoDauthFunctions.ps1

+[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseDeclaredVarsMoreThanAssignments', '', Justification = 'Variables are being used in functions')]
+[CmdletBinding()]
+param (
+    [Parameter(Mandatory = $false)]
+    [String] $tdEXOOrgRelDomainNamesColor
+)


Again, we shouldn't be having this type of a start of a file that we are just importing into a different main script.

Mistake, removed

dpaulson45 · 2024-03-20T14:05:11Z

Diagnostics/FreeBusyChecker/Functions/htmlContent.ps1

+[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseDeclaredVarsMoreThanAssignments', '', Justification = 'Variables are being used in functions')]
+[CmdletBinding()]
+param (
+    [Parameter(Mandatory = $false)]
+    [String] $tdDomainNamesColor
+)


Again, we shouldn't be having this type of a start of a file that we are just importing into a different main script.

Mistake, removed

lusassl-msft · 2024-06-13T07:56:39Z

@MarcoLFrancisco do you still work on this PR? Please re-request a review once this is ready to be reviewed. Thanks.

dpaulson45 · 2024-06-19T19:56:16Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+        $exchangeServer = Get-ExchangeServer -ErrorAction SilentlyContinue | Where-Object { $_.Name -eq $Server }
+        if (!$exchangeServer) {
+            Write-Output "$Server is not an Exchange Server. This script need to be run in an Exchange Server 2013, 2016 or 2019"
+            break


Break doesn't exit the script. We will till continue.

Changed to Return. Correction will be available when changes are pushed.

dpaulson45 · 2024-06-19T19:58:10Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+        param (
+            [string]$Server
+        )
+        $exchangeServer = Get-ExchangeServer -ErrorAction SilentlyContinue | Where-Object { $_.Name -eq $Server }


This is a very expensive call to be making. you are returning all the servers vs just trying to find a single server that is much quicker.

try { Get-ExchangeServer -ErrorAction Stop $Server | Out-Null } catch { Write-Host "$Server is not an Exchange Server. This script needs to be run on an Exchange Server." exit }

Changed to:

$exchangeServer = Get-ExchangeServer $server -ErrorAction SilentlyContinue
if (!$exchangeServer) {
Write-Output "$Server is not an Exchange Server. This script need to be run in an Exchange Server version 2013, 2016 or 2019"
return
}

Correction will be available when changes are pushed.

dpaulson45 · 2024-06-19T19:59:37Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+        }
+
+        if (-not (Get-Module -Name ExchangeOnlineManagement -ListAvailable)) {
+            Disconnect-ExchangeOnline -Confirm:$False


We should not be disconnecting from sessions within our scripts, unless we are the ones that created it but we also don't like doing that.

Removed from code. Change will be available when changes are pushed.

dpaulson45 · 2024-06-19T20:00:15Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+} end {
+    function InstallRequiredModules {
+        try {
+            Get-Command -Module ActiveDirectory -ErrorAction Stop >$null


We should be using #Requires -Module ActiveDirectory in the script inside of doing this.

https://powershellisfun.com/2023/04/24/using-the-requires-statement-in-powershell/

Adding #Requires -Module ActiveDirectory and removing this check

Removed this funciton and function call as it is not needed

function InstallRequiredModules {
try {
Get-Command -Module ActiveDirectory -ErrorAction Stop >$null
} catch {
Import-Module ActiveDirectory
}

if (-not (Get-Module -Name ExchangeOnlineManagement -ListAvailable)) { Disconnect-ExchangeOnline -Confirm:$False } }

dpaulson45 · 2024-06-19T20:12:02Z

Diagnostics/FreeBusyChecker/Functions/OnPremDAuthFunctions.ps1

+function EWSVirtualDirectoryCheck {
+    Write-Host -ForegroundColor Green " Get-WebServicesVirtualDirectory -Server $($server)| Select Identity,Name,ExchangeVersion,*Authentication*,*url"
+    PrintDynamicWidthLine
+    $Script:WebServicesVirtualDirectory = Get-WebServicesVirtualDirectory -Server $server | Select-Object Identity, Name, ExchangeVersion, *Authentication*, *url -ErrorAction SilentlyContinue


This is the second time running this cmdlet, we should avoid doing that.

Corrected, Get-WebServicesVirtualDirectory is only exectuted if not execiuted before. If it has been previuosly exevuted it now uses variable content. Correction will be available when changes are pushed.

A new file was added to hold functions that are common to OAuth and Dauth

dpaulson45 · 2024-06-19T20:14:47Z

Diagnostics/FreeBusyChecker/Functions/ExoOauthFunctions.ps1

+[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseDeclaredVarsMoreThanAssignments', '', Justification = 'Variables are being used in functions')]
+param (
+    [Parameter(Mandatory = $false)]
+    [String] $tdEXOIntraOrgConTarGetAddressDomains
+)


Removed from code. Correction will be available when changes are pushed.

dpaulson45 · 2024-06-19T20:15:00Z

Diagnostics/FreeBusyChecker/Functions/ExoDauthFunctions.ps1

+[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseDeclaredVarsMoreThanAssignments', '', Justification = 'Variables are being used in functions')]
+param (
+    [Parameter(Mandatory = $false)]
+    [String] $tdEXOOrgRelDomainNamesColor
+)


Removed from code. Correction will be available when changes are pushed.

dpaulson45 · 2024-06-19T20:15:47Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+        if (-not (Get-Module -Name ExchangeOnlineManagement -ListAvailable)) {
+            # If not installed, then install the module
+            Write-Host -ForegroundColor Yellow $ExchangeOnlinePowershellModuleMessage
+            Install-Module -Name ExchangeOnlineManagement -Force
+            PrintDynamicWidthLine


Let's use #Requires for the module check

If the user wishes to check only On Premises settings, Exchange Online Management module is not needed. This is very common on DAuth Free busy. Should I implement Requires in this case?

dpaulson45 · 2024-06-19T20:16:34Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+        }
+        #endregion
+
+        Disconnect-ExchangeOnline  -Confirm:$False


We should not be disconnecting from Exchange Online powershell session. We don't want to be modifying admins current connections.

dpaulson45 · 2024-06-19T20:17:25Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+            PrintDynamicWidthLine
+        }
+
+        Connect-ExchangeOnline -ShowBanner:$false


Do not connect, this should already be done by the admin prior to running the script. Only thing we should be doing is verifying that we are connected.

dpaulson45 · 2024-07-25T15:28:36Z

@MarcoLFrancisco do you still want to work on this PR? Otherwise, we will close this out.

dpaulson45 · 2024-08-08T13:53:55Z

Closing out as no updates since March.

MarcoLFrancisco · 2024-08-09T09:10:21Z

Good morning, my appologies but I missed last comments. Can the pull request be reactivated?

lusassl-msft · 2024-08-09T09:34:25Z

Reopened as requested by @MarcoLFrancisco

MarcoLFrancisco · 2024-08-09T09:39:50Z

Good morning,

I will start to address the last recomendations this weekend. I believe i can probably finish them during the weekend, if not they should all be addressed no latter than the following weekend.

MarcoLFrancisco · 2024-08-19T23:18:08Z

All changes are now implemented. I need a few more days for testing to confirm all functions are working and html output is correctly formated

dpaulson45 · 2024-08-20T13:21:32Z

Please comment on here once you are ready for us to review the script again.

Pushing requested changes

MarcoLFrancisco · 2024-08-23T23:38:38Z

I believe changes are now commited

dpaulson45 · 2024-08-26T13:23:45Z

Failing spell check:

MarcoLFrancisco · 2024-08-27T09:44:53Z

Not sure why, I did spelcheck on two different machines, PC and Mac. I will correct this items.

Pushing requested Changes

MarcoLFrancisco · 2024-08-27T21:35:44Z

Pushed the Spellcheck requested changes. Not sure if more exist or if correction wont triger same warning. Appologies if it does

dpaulson45 · 2024-08-28T14:04:43Z

@MarcoLFrancisco I was running into the same problem. Looks like we need to update on the client side.

npm install -g cspell run that in your terminal, then you should be able to run it like you were.

MarcoLFrancisco · 2024-08-28T15:57:22Z

@MarcoLFrancisco I was running into the same problem. Looks like we need to update on the client side.

npm install -g cspell run that in your terminal, then you should be able to run it like you were.

Thank you so much, I even tested on two PC's . I will update and review again.

Pushing changes after Spell check update

MarcoLFrancisco · 2024-08-30T22:24:53Z

Spell Check on PC worked, returned spell errors and i could address them.
Thank you very much for the tip :-)

dpaulson45 · 2024-09-03T14:13:18Z

Diagnostics/FreeBusyChecker/Functions/CommonFunctions.ps1

+    $exchangeServer = Get-ExchangeServer $server -ErrorAction SilentlyContinue
+    if (!$exchangeServer) {
+        Write-Output "$Server is not an Exchange Server. This script need to be run in an Exchange Server version 2013, 2016 or 2019"
+        return


A return is only going to return from the current function and all the script to move forward and you don't stop the script here. We need to switch this to an exit.

Changed to exit

dpaulson45 · 2024-09-03T14:13:51Z

Diagnostics/FreeBusyChecker/Functions/CommonFunctions.ps1

+    )
+    $exchangeServer = Get-ExchangeServer $server -ErrorAction SilentlyContinue
+    if (!$exchangeServer) {
+        Write-Output "$Server is not an Exchange Server. This script need to be run in an Exchange Server version 2013, 2016 or 2019"


Let's remove Exchange Version number in a hard coded string display.

dpaulson45 · 2024-09-04T18:00:55Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+- Exchange Server 2013
+- Exchange Server 2016
+- Exchange Server 2019


Maybe change this to just Exchange Server

dpaulson45 · 2024-09-04T18:07:13Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+    $Script:AutoDiscoveryVirtualDirectory = $null
+    $Script:OrgRel = $null
+    $Script:SPDomainsOnprem = $null
+    $AvailabilityAddressSpace = $null


This isn't required to be here as you set it in the other functions and only use it there.

dpaulson45 · 2024-09-04T18:09:50Z

Diagnostics/FreeBusyChecker/Functions/OnPremDAuthFunctions.ps1

+        $countOrgRelIssues++
+    }
+    # Display the settings list
+    if ($countOrgRelIssues -eq '0') {


We shouldn't be doing this; you are comparing an int to a string. PowerShell likely works, but this is a bad habit.

Changed to "if ($countOrgRelIssues -eq 0)"

dpaulson45 · 2024-09-04T18:16:24Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+    $AvailabilityAddressSpace = $null
+    $Script:WebServicesVirtualDirectory = $null
+    $ConsoleWidth = $Host.UI.RawUI.WindowSize.Width
+    $BuildVersion = ""


Move to the function where we use this variable.

dpaulson45 · 2024-09-04T18:17:29Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+    $Server = hostname
+    $LogFile = "$PSScriptRoot\FreeBusyChecker.txt"
+    $startingDate = (Get-Date -Format yyyyMMdd_HHmmss)
+    $LogFileName = [System.IO.Path]::GetFileNameWithoutExtension($LogFile) + "_" + $startingDate + ([System.IO.Path]::GetExtension($LogFile))


Move to the function where we are using this variable.

dpaulson45 · 2024-09-04T18:18:41Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+    $LogFile = "$PSScriptRoot\FreeBusyChecker.txt"
+    $startingDate = (Get-Date -Format yyyyMMdd_HHmmss)
+    $LogFileName = [System.IO.Path]::GetFileNameWithoutExtension($LogFile) + "_" + $startingDate + ([System.IO.Path]::GetExtension($LogFile))
+    $htmlFile = "$PSScriptRoot\FBCheckerOutput_$($startingDate).html"


Set this to be a $Script: variable, as we do use this in multiple locations.

dpaulson45 · 2024-09-04T18:19:54Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+#>
+#region Properties and Parameters
+
+[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseDeclaredVarsMoreThanAssignments', '', Justification = 'Variables are being used')]


Let's remove this, this should only be used for parameters that are never used in the initial script file. Which all of them appear to be. Then it is just a matter of addressing the other problems below.

dpaulson45 · 2024-09-04T18:24:23Z

docs/Diagnostics/FreeBusyChecker/FreeBusyChecker.md

+Syntax:
+
+    FreeBusyChecker.ps1


use the same format that is in SourceSideValidations.md

I believe it is as intended now.

MarcoLFrancisco · 2024-09-11T09:53:39Z

Good morning. I have been out of office for some days. Will implement corrections as soon as possible.

MarcoLFrancisco · 2024-10-15T22:30:59Z

Changes are almost completed. Expect to be concluded and tested in the next days.

Edited CommonFunctions.ps1; hostOutput.ps1; htmlContent.ps1; OnPremDAuthFunctions.ps1; FreeBusyChecker.ps1

MarcoLFrancisco · 2024-10-17T20:29:30Z

Requested changes are now published

dpaulson45 · 2024-10-21T18:16:40Z

/azp run

azure-pipelines · 2024-10-21T18:16:50Z

Azure Pipelines successfully started running 1 pipeline(s).

dpaulson45 · 2024-10-23T14:27:07Z

Diagnostics/FreeBusyChecker/Functions/CommonFunctions.ps1

+        [string]$Server
+    )
+    $exchangeServer = Get-ExchangeServer $Script:Server -ErrorAction SilentlyContinue


Using two different variables here for $Server. The parameter of $Server is local, where the $Script:Server is a script scope variable. So you can have these as two different variables.

Since this function is only really used once, is it really needed if it isn't complicated?

dpaulson45 · 2024-10-23T14:36:47Z

Diagnostics/FreeBusyChecker/Functions/hostOutput.ps1

+    $LogFileName = [System.IO.Path]::GetFileNameWithoutExtension($LogFile) + "_" + $Script:startingDate + ([System.IO.Path]::GetExtension($Script:LogFile))
+    Write-Host " `n`n "
+    Write-Host " `n`n "
+    Start-Transcript -Path $LogFileName -Append


Since you only appear to have Write-Host in the script this works. However, it makes the end user text file rather wordy. A better option is to only display the needed information, and then for diagnostic purposes, like script troubleshooting, have that information in Write-Verbose which is not captured in Start-Transcript unless they provide -Verbose.

We do have logging functions already created in the share, but this isn't required at this time.

dpaulson45 · 2024-10-23T14:59:35Z

docs/Diagnostics/FreeBusyChecker/FreeBusyChecker.md

+To View this Project at GitHub! [GitHub Repository](https://github.com/MarcoLFrancisco/Hybrid-Free-Busy-Configuration-Checker)
+
+To Download the latest release: [FreeBusyChecker.ps1](https://github.com/MarcoLFrancisco/Hybrid-Free-Busy-Configuration-Checker/releases/download/Version1/FreeBusyChecker.ps1)


update links to point to our repository and using the correct download link location.

dpaulson45 · 2024-10-23T17:53:01Z

docs/Diagnostics/FreeBusyChecker/FreeBusyChecker.md

+- This is a Beta Version. Please double check on any information provided by this script before proceeding to address any changes to your Environment. Be advised that there may be incorrect content in the provided output.
+
+Use: Collects OAuth and DAuth Hybrid Availability Configuration Settings Both for Exchange On Premises and Exchange Online
+


Need to include information about how they need to connect to Exchange Online with the -Prefix

Connect-ExchangeOnline -Prefix EO

dpaulson45 · 2024-10-29T20:42:19Z

Diagnostics/FreeBusyChecker/FreeBusyChecker.ps1

+    if ($Org -contains 'ExchangeOnPremise' -or -not $Org) {
+        #region DAuth Checks
+        if ($Auth -like "DAuth" -OR -not $Auth -or $Auth -like "All") {
+            Write-Host $TestingDAuthConfiguration


Empty variable

dpaulson45 · 2024-10-29T21:14:50Z

Diagnostics/FreeBusyChecker/Functions/ExoDauthFunctions.ps1

+        if ($Script:tdExoOrgRelDomainNamesData -or $Script:tdExoOrgRelDomainNamesColor) {
+        }


Looks like we are missing something here.

dpaulson45 · 2024-10-29T21:15:09Z

Diagnostics/FreeBusyChecker/Functions/ExoDauthFunctions.ps1

+        if ($Script:tdExoOrgRelFreeBusyAccessEnabled -or $Script:tdExoOrgRelFreeBusyAccessEnabledColor) {
+        }


Looks like we are missing something here.

dpaulson45 · 2024-10-29T21:27:01Z

Diagnostics/FreeBusyChecker/Functions/OnPremOAuthFunctions.ps1

+    PrintDynamicWidthLine
+    $Script:OAuthConnectivity = Test-OAuthConnectivity -Service EWS -TarGetUri https://outlook.office365.com/EWS/Exchange.asmx -Mailbox $Script:UserOnPrem
+    if ($Script:OAuthConnectivity.ResultType -eq 'Success' ) {
+        #$Script:OAuthConnectivity.ResultType


Empty if statement with a comment. Determine if this is needed, otherwise, remove if statement.

dpaulson45 · 2024-10-29T21:27:27Z

Diagnostics/FreeBusyChecker/Functions/OnPremOAuthFunctions.ps1

+    $AD = $AutoDiscoveryVirtualDirectoryOAuth | Format-List
+    $AD
+    AutoDVirtualDCheckOauthHtmlHead
+    if ($Auth -contains "OAuth") {


Empty if statement

dpaulson45 · 2024-10-29T21:28:02Z

Diagnostics/FreeBusyChecker/Functions/OnPremOAuthFunctions.ps1

+    if ($Auth -contains "OAuth") {
+    }


Empty if statement

dpaulson45 · 2024-10-29T21:31:36Z

Due to a code formatting rule change, you will need to run that locally and address the issues seen there.

dpaulson45 · 2024-11-26T22:04:04Z

@MarcoLFrancisco please review the PR and make the required adjustments.

MarcoLFrancisco and others added 2 commits November 22, 2023 17:19

Adding a new script to check for Hybrid Free Busy

d981faf

Merge branch 'microsoft:main' into main

ae810aa

MarcoLFrancisco requested a review from a team as a code owner January 9, 2024 15:40

dpaulson45 requested changes Jan 9, 2024

View reviewed changes

MarcoLFrancisco and others added 10 commits February 1, 2024 15:29

Merge branch 'main' into main

4b58a7e

Merge branch 'main' into main

1ff72a0

Updating with requested changes

f26fc4c

Deleting Folder with script test output results

35acbe4

Updating with requested changes

baecae0

Merge branch 'microsoft:main' into main

46f8dbb

Pushing after fixing Code Formating and removing extra empty lines

1ec6e1b

Commiting remaining requested changes

693465f

Merge branch 'main' into main

9cafe04

Commiting requested changes. Typo fix from previous commit

a85d4a4

dpaulson45 reviewed Mar 20, 2024

View reviewed changes

Commiting latest changes for requested corrections

3739ad1

dpaulson45 reviewed Jun 19, 2024

View reviewed changes

dpaulson45 closed this Aug 8, 2024

Merge branch 'microsoft:main' into main

35ee6d8

lusassl-msft reopened this Aug 9, 2024

MarcoLFrancisco and others added 2 commits August 23, 2024 22:28

Merge branch 'main' into main

247bd46

FreeBusyChecker_EDITMSG

aa1f298

Pushing requested changes

FreeBusyChecker_EDITMSG

82f83e4

Pushing requested Changes

Merge branch 'main' into main

5543025

FreeBusyChecker_EDITMSG

bea61ba

Pushing changes after Spell check update

dpaulson45 reviewed Sep 4, 2024

View reviewed changes

MarcoLFrancisco and others added 2 commits October 17, 2024 21:24

Publishing Requested changes for FreeBusyCheckerScript

7cc0e17

Edited CommonFunctions.ps1; hostOutput.ps1; htmlContent.ps1; OnPremDAuthFunctions.ps1; FreeBusyChecker.ps1

Merge branch 'main' into main

3ff48cf

Merge branch 'main' into main

26b1f56

dpaulson45 requested changes Oct 29, 2024

View reviewed changes

Merge branch 'main' into main

63c019b


		if (-not $OnPremEWSUrl) {

		$EWSVirtualDirectory = Get-WebServicesVirtualDirectory -server $Server -ErrorAction SilentlyContinue

		To View this Project at GitHub! [GitHub Repository](https://github.com/MarcoLFrancisco/Hybrid-Free-Busy-Configuration-Checker)

		To Download the latest release: [FreeBusyChecker.ps1](https://github.com/MarcoLFrancisco/Hybrid-Free-Busy-Configuration-Checker/releases/download/Version1/FreeBusyChecker.ps1)

		- This is a Beta Version. Please double check on any information provided by this script before proceeding to address any changes to your Environment. Be advised that there may be incorrect content in the provided output.

		Use: Collects OAuth and DAuth Hybrid Availability Configuration Settings Both for Exchange On Premises and Exchange Online

		if ($Script:tdExoOrgRelDomainNamesData -or $Script:tdExoOrgRelDomainNamesColor) {
		}

		if ($Script:tdExoOrgRelFreeBusyAccessEnabled -or $Script:tdExoOrgRelFreeBusyAccessEnabledColor) {
		}

Hybrid Free Busy Configuration Checker #1934

Are you sure you want to change the base?

Hybrid Free Busy Configuration Checker #1934

Conversation

MarcoLFrancisco commented Jan 9, 2024

dpaulson45 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MarcoLFrancisco Feb 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MarcoLFrancisco Feb 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MarcoLFrancisco Feb 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lusassl-msft commented Jun 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dpaulson45 commented Jul 25, 2024

dpaulson45 commented Aug 8, 2024

MarcoLFrancisco commented Aug 9, 2024

lusassl-msft commented Aug 9, 2024

MarcoLFrancisco commented Aug 9, 2024

MarcoLFrancisco commented Aug 19, 2024 • edited Loading

dpaulson45 commented Aug 20, 2024

MarcoLFrancisco Feb 18, 2024 •

edited

Loading

MarcoLFrancisco Feb 1, 2024 •

edited

Loading

MarcoLFrancisco Feb 1, 2024 •

edited

Loading

MarcoLFrancisco commented Aug 19, 2024 •

edited

Loading