Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable extended logging in DiagnosticsObserversInitializer by default #368

Open
dakanev-msft opened this issue Jun 9, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@dakanev-msft
Copy link
Member

dakanev-msft commented Jun 9, 2021

By default the DiagnosticsObserversInitializer logs extended details when the HttpClient receives an error response. In particular cases the log entry can contain the payload of the HTTP request message including Authorization and custom header values. This is a concern from privacy and security perspective as the header values might contain personally identifiable information and non encrypted access tokens.

Extended logging information should be off by default and should be explicitly enabled so that developers are in control of what is being logged.

@dakanev-msft dakanev-msft added the bug Something isn't working label Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants