Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Move to bcrypt from bcrypt-nodejs #244

Open
davl3232 opened this issue Oct 28, 2019 · 2 comments
Open

Move to bcrypt from bcrypt-nodejs #244

davl3232 opened this issue Oct 28, 2019 · 2 comments

Comments

@davl3232
Copy link

This project uses bcrypt-nodejs library for hashing and salting user passwords. That library seems very outdated, to the point there's a notice on its NPM page.

Now there's bcrypt that supports both promises and callbacks. It also looks well maintained and has typescript types available.

Can it be changed? Or is there a reason for using bcrypt-nodejs?

@peterblazejewicz
Copy link
Collaborator

Hi,
It was obviously missed in the output of the default install. The NPM outdated does not report this, so it was probably just overlooked.
Yes, could be done, prefferably in the default, async version (no promises), to keep in sync with other existing code. I'd help you with a PR if you would like to do one,
Thanks!

@davl3232
Copy link
Author

Hey Peter, I just submitted #245 with this change.
Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants