Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bloomberg feedback for 5.7 #60611

Open
1 task done
dragomirtitian opened this issue Nov 26, 2024 · 0 comments
Open
1 task done

Bloomberg feedback for 5.7 #60611

dragomirtitian opened this issue Nov 26, 2024 · 0 comments
Labels
Discussion Issues which may not have code impact

Comments

@dragomirtitian
Copy link
Contributor

Acknowledgement

  • I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion.

Comment

We evaluated the 5.7 release and it seems to be a low impact release for us. We only found one issue, which we reported:

# Change Affects Release notes Packages affected Reported As
1 Index signature added to classes that inherit an any typed class Declaration Emit Not Announced <1% #60383
2 Minor changes to declaration text Declaration Emit Not Announced <1%

Minor changes to declaration text

These seem to be related to isolated declaration emit alignment with external tools. The changes were in a limited number of places and did not impact the correctness of the declarations (some string delimiters changed, some types got preserved as typeof x instead being inlined, some recursive types got expanded one level deeper).

Examples:

-  get sourceFn(): SourceFnArgs<TParams>['sourceFn'];
+  get sourceFn(): SourceFnArgs<TParams>["sourceFn"];

+ readonly Source: any;
- readonly Source: typeof LazySource.default;
@RyanCavanaugh RyanCavanaugh added the Discussion Issues which may not have code impact label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issues which may not have code impact
Projects
None yet
Development

No branches or pull requests

2 participants