Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] Enhancement: Improve tcp-echo #1457

Closed
wants to merge 1 commit into from

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Nov 13, 2024

Remove data structure from tcp-echo that impacts performance.

Copy link

libos = catnap
commit id = 9194a6a

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::catnap::transport::epoll 13360296.10 2006.72 889.33 32.06
register 14016.25 41.61 18.30 0.00
unregister 14015.25 50.33 22.14 0.00
demikernel::sgafree 11536.09 73.15 31.65 0.04
demikernel::sgaalloc 11283.68 115.73 51.31 0.09
ioc::network::libos::push;catnap::linux::transport::push 9066.12 664.71 294.81 4.16
ioc::network::libos::push 8800.49 16633.40 7385.04 5.45
demikernel::push 8800.49 561.63 247.89 0.14
ioc::network::libos::pop;catnap::linux::transport::pop 8024.13 421.55 184.09 4.23
ioc::network::libos::pop 7815.65 17722653.37 7906350.23 25.67
demikernel::pop 7815.65 550.57 238.59 0.10
ioc::network::libos::pushto 607.67 7354.68 3082.27 23.54
ioc::network::libos::pushto;catnap::linux::transport::push 607.67 454.61 190.39 6.18
demikernel::pushto 607.67 441.10 184.91 1.42
demikernel::async_close 32.50 1140.58 468.11 0.01
ioc::network::libos::connect 24.95 6927586.56 3083425.16 27.98
ioc::network::libos::connect;catnap::linux::transport::connect 24.95 75968.89 33572.92 2.57
demikernel::connect 24.95 1976.44 880.30 0.01
ioc::network::libos::close 18.35 24736.55 10815.14 0.07
ioc::network::libos::close;catnap::linux::transport::close 18.35 23362.12 10212.29 94.54
demikernel::accept 15.42 1447.89 631.41 0.00
ioc::network::libos::accept 15.39 909191451.93 395944537.39 46.18
ioc::network::libos::accept;catnap::linux::transport::accept 15.39 5088.10 2280.52 0.00
demikernel::socket 9.50 153126.52 67804.40 0.31
demikernel::socket;catnap::linux::transport::socket 9.50 150675.85 66733.15 96.39
demikernel::new 1.00 262683.56 114636.24 0.14
demikernel::bind 1.00 28978.02 12580.07 0.01
demikernel::bind;catnap::linux::transport::bind 1.00 24362.58 10575.86 84.04
demikernel::listen 1.00 14968.29 6496.53 0.00
demikernel::listen;catnap::linux::transport::listen 1.00 14041.08 6095.77 93.78
demikernel::close 0.00 nan nan 0.00

Copy link

libos = catnap
commit id = f3a2109

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::catnap::transport::epoll 13405989.77 2018.97 882.54 32.37
register 14016.25 42.07 18.42 0.00
unregister 14015.25 52.26 22.91 0.00
demikernel::sgafree 11536.49 74.76 31.92 0.04
demikernel::sgaalloc 11284.78 114.65 49.53 0.09
ioc::network::libos::push;catnap::linux::transport::push 9066.12 609.82 267.26 3.84
ioc::network::libos::push 8800.49 16444.21 7191.23 5.94
demikernel::push 8800.49 531.93 231.66 0.14
ioc::network::libos::pop;catnap::linux::transport::pop 8023.19 386.07 166.90 3.84
ioc::network::libos::pop 7814.73 17602903.90 8302438.92 25.88
demikernel::pop 7814.73 544.81 233.29 0.11
ioc::network::libos::pushto 623.33 8458.04 3962.93 23.34
ioc::network::libos::pushto;catnap::linux::transport::push 623.33 518.48 243.18 6.14
demikernel::pushto 623.33 497.94 233.36 1.44
demikernel::async_close 32.50 1065.58 420.66 0.01
ioc::network::libos::connect 24.95 4268132.83 1903517.82 26.59
ioc::network::libos::connect;catnap::linux::transport::connect 24.95 77660.10 33718.74 2.81
demikernel::connect 24.95 1988.76 876.88 0.01
ioc::network::libos::close 18.35 25135.75 10923.79 0.06
ioc::network::libos::close;catnap::linux::transport::close 18.35 23450.46 10183.04 93.61
demikernel::accept 15.42 1450.45 627.98 0.00
ioc::network::libos::accept 15.41 890559610.91 383544088.69 45.57
ioc::network::libos::accept;catnap::linux::transport::accept 15.39 3342.09 1425.93 0.00
demikernel::socket 9.50 156548.05 70259.11 0.31
demikernel::socket;catnap::linux::transport::socket 9.50 153837.82 69077.31 96.12
demikernel::new 1.00 262002.11 113060.61 0.11
demikernel::bind 1.00 28751.45 12506.64 0.01
demikernel::bind;catnap::linux::transport::bind 1.00 24448.15 10645.57 84.56
demikernel::listen 1.00 15250.26 6575.60 0.00
demikernel::listen;catnap::linux::transport::listen 1.00 14036.79 6054.50 91.82
demikernel::close 0.00 nan nan 0.00

Copy link

libos = catnap
commit id = c16875b

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::catnap::transport::epoll 13354840.29 1699.32 737.60 33.27
register 14016.25 41.01 18.13 0.00
unregister 14015.25 49.06 21.68 0.00
demikernel::sgafree 11540.77 74.91 32.35 0.05
demikernel::sgaalloc 11296.40 143.41 60.74 0.11
ioc::network::libos::push;catnap::linux::transport::push 9066.12 649.09 286.20 4.09
ioc::network::libos::push 8800.49 16604.04 7311.48 6.67
demikernel::push 8800.49 553.94 242.40 0.16
ioc::network::libos::pop;catnap::linux::transport::pop 8023.10 399.86 175.06 3.17
ioc::network::libos::pop 7814.64 16211576.09 6312607.51 23.69
demikernel::pop 7814.64 543.37 235.69 0.13
ioc::network::libos::pushto 790.33 7300.63 2990.99 23.93
demikernel::pushto 790.33 443.98 181.98 1.48
ioc::network::libos::pushto;catnap::linux::transport::push 790.33 434.24 177.88 5.96
demikernel::async_close 32.50 1023.69 424.68 0.01
ioc::network::libos::connect 24.95 6523848.58 2816040.98 29.45
ioc::network::libos::connect;catnap::linux::transport::connect 24.95 78202.81 33927.28 2.16
demikernel::connect 24.95 2077.07 909.63 0.01
ioc::network::libos::close 18.35 24971.75 10862.92 0.05
ioc::network::libos::close;catnap::linux::transport::close 18.35 23556.32 10238.38 94.48
demikernel::accept 15.42 1521.45 669.95 0.00
ioc::network::libos::accept 15.39 878877770.73 387695128.77 44.78
ioc::network::libos::accept;catnap::linux::transport::accept 15.39 8794.58 3814.25 0.00
demikernel::socket 9.50 154998.04 67479.44 0.25
demikernel::socket;catnap::linux::transport::socket 9.50 152271.71 66296.18 96.02
demikernel::new 1.00 259804.02 112933.39 0.11
demikernel::bind 1.00 29082.28 12664.41 0.01
demikernel::bind;catnap::linux::transport::bind 1.00 24693.90 10747.48 84.72
demikernel::listen 1.00 15641.66 6844.39 0.00
demikernel::listen;catnap::linux::transport::listen 1.00 14277.53 6244.71 92.55
demikernel::close 0.00 nan nan 0.00

@anandbonde
Copy link
Contributor

This change doesn’t seem to have any effect on the performance so we will just leave it here.

@anandbonde anandbonde closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants