Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebpf-verifier is cloned twice #4174

Open
dthaler opened this issue Feb 3, 2025 · 0 comments
Open

ebpf-verifier is cloned twice #4174

dthaler opened this issue Feb 3, 2025 · 0 comments
Assignees
@Alan-Jowett
Labels
blocked Blocked on another issue that must be done first cleanup Affects API usability or code maintainability but not correctness or applicability good first issue Good for newcomers P3 triaged Discussed in a triage meeting
Milestone
2505

Comments

@dthaler
Copy link
Collaborator

dthaler commented Feb 3, 2025

Describe the bug

We have

  • external\ebpf-verifier
  • external\ubpf\external\ebpf-verifier

This just consumes extra disk space and time/bandwidth to clone and update. It would be more efficient to only clone one copy.
We could either:

  1. Remove external\ebpf-verifier and just use the one under ubpf. The disadvantage is that we couldn't update the verifier until ubpf is updated. Or,
  2. Do a shallow clone of ubpf.

OS information

No response

Steps taken to reproduce bug

Clone the repository recursively
dir /s ebpf-verifier

Expected behavior

Only one copy present

Actual outcome

Two copies present

Additional details

No response
@dthaler dthaler added cleanup Affects API usability or code maintainability but not correctness or applicability good first issue Good for newcomers P3 labels Feb 3, 2025
@shankarseal shankarseal added the blocked Blocked on another issue that must be done first label Feb 3, 2025
@shankarseal shankarseal added this to the 2505 milestone Feb 3, 2025
@shankarseal shankarseal added the triaged Discussed in a triage meeting label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alan-Jowett Alan-Jowett

Labels
blocked Blocked on another issue that must be done first cleanup Affects API usability or code maintainability but not correctness or applicability good first issue Good for newcomers P3 triaged Discussed in a triage meeting
Projects
None yet
Milestone
2505
Development

No branches or pull requests
3 participants
@dthaler @Alan-Jowett @shankarseal