Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tagsByResource not being applied to stop all triggers deployment script #1330

Open
flamableassassin opened this issue Feb 19, 2025 · 0 comments
Open

tagsByResource not being applied to stop all triggers deployment script #1330

flamableassassin opened this issue Feb 19, 2025 · 0 comments
Labels
OKR: 1.2 Reliability Issues that improve reliability and resiliency Skill: Deployment Resource deployment automation via bicep or terraform Tool: FinOps hubs Data pipeline solution Type: Bug 🐛 Something isn't working
Milestone
2025-03 - March

Comments

@flamableassassin
Copy link

🐛 Problem

tagsByResource not being applied to stop all triggers deployment script

https://github.com/microsoft/finops-toolkit/blob/v0.8/src/templates/finops-hub/modules/dataFactory.bicep#L383

👣 Repro steps

  1. Deploy
  2. Check tags on the stop triggers deployment script

🤔 Expected

The deployment script has tags

ℹ️ Additional context

We have a policy that has the side effect of applying to deployment scripts but we can use tags to bypass it. But because the tag isn't applied to this script it denies the script and fails.

🙋‍♀️ Ask for the community

We could use your help:

  1. Please vote this issue up (👍) to prioritize it.
  2. Leave comments to help us solidify the vision.
@flamableassassin flamableassassin added Needs: Triage 🔍 Untriaged issue needs to be reviewed Type: Bug 🐛 Something isn't working labels Feb 19, 2025
@flamableassassin flamableassassin mentioned this issue Feb 19, 2025
Closed
@flanakin flanakin added Skill: Deployment Resource deployment automation via bicep or terraform Tool: FinOps hubs Data pipeline solution and removed Needs: Triage 🔍 Untriaged issue needs to be reviewed labels Feb 25, 2025
@flanakin flanakin added this to the 2025-03 - March milestone Feb 25, 2025
@flanakin flanakin added the OKR: 1.2 Reliability Issues that improve reliability and resiliency label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OKR: 1.2 Reliability Issues that improve reliability and resiliency Skill: Deployment Resource deployment automation via bicep or terraform Tool: FinOps hubs Data pipeline solution Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
2025-03 - March
Development

Successfully merging a pull request may close this issue.

Fixing tags not being applied to stop all triggers deployment script flamableassassin/finops-toolkit
2 participants
@flanakin @flamableassassin