Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "1000 TB" pricing unit mapping #1287

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Add "1000 TB" pricing unit mapping #1287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c642ce2
Add "1000 TB" pricing unit mapping
flanakin Feb 3, 2025
8f7e465
Update PS and changelog
flanakin Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions docs/_resources/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,9 @@ Legend:
>
> 1. Added explicit `-CommitmentDiscountScope`, `-CommitmentDiscountResourceType`, and `-CommitmentDiscountLookback` parameters to the [New-FinOpsCostExport command](../_automation/powershell/cost/New-FinOpsCostExport.md) for reservation recommendations.
> 1. Added explicit `-SystemAssignedIdentity` switch parameter to the [New-FinOpsCostExport command](../_automation/powershell/cost/New-FinOpsCostExport.md) to enable system-assigned identity.
> 1. Updated the [Remove-FinOpsHub command](../_automation/powershell/hubs/Remove-FinOpsHub.md) to show a list of resources before confirming delete.
> - The name of each deleted resource is printed for better visibility during the deletion process.
> - Added ability to confirm all deletions using a "Yes to All" option ([#1187](https://github.com/microsoft/finops-toolkit/issues/1187)).
>
> ✏️ Changed:
>
Expand Down Expand Up @@ -211,25 +214,18 @@ Legend:
>
> 🛠️ Fixed:
>
> 1. Fixed the [New-FinOpsCostExport command](../_automation/powershell/cost/New-FinOpsCostExport.md) to work for prices, reservation recommendations, and reservation transactions. ([#1193](https://github.com/microsoft/finops-toolkit/issues/1193)).
> 1. Fixed the [New-FinOpsCostExport command](../_automation/powershell/cost/New-FinOpsCostExport.md) to work for prices, reservation recommendations, and reservation transactions ([#1193](https://github.com/microsoft/finops-toolkit/issues/1193)).

🌐 Open data
{: .fs-5 .fw-500 .mt-4 mb-0 }

> ➕ Added:
>
> - [Pricing units](../_reporting/data/README.md#-pricing-units)
> 1. Added the "1000 TB" unit of measure ([#1181](https://github.com/microsoft/finops-toolkit/issues/1181)).
> - [Resource types](../_reporting/data/README.md#-resource-types)
> 1. Added 2 new Microsoft.Network DNS resolver resource types.

🖥️ PowerShell
{: .fs-5 .fw-500 .mt-4 mb-0 }

> ➕ Added:
>
> 1. Updated the [Remove-FinOpsHub command](../_automation/powershell/hubs/Remove-FinOpsHub.md) to show a list of resources before confirming delete.
> - The name of each deleted resource is printed for better visibility during the deletion process.
> - Added ability to confirm all deletions using a "Yes to All" option ([#1187](https://github.com/microsoft/finops-toolkit/issues/1187)).

<br>

## 🪛 v0.7 Update 1
Expand Down
1 change: 1 addition & 0 deletions src/open-data/PricingUnits.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ UnitOfMeasure,AccountTypes,PricingBlockSize,DistinctUnits
"1000 Relay Hours",EA,1000,Hours
"1000 Relay Hrs",EA,1000,Hours
"1000 Renders",EA,1000,Renders
"1000 TB",,1000,TB
"1000 Transactions",EA,1000,Transactions
"10000",EA,10000,Units
"10000 ",EA,10000,Units
Expand Down
1 change: 1 addition & 0 deletions src/powershell/Private/Get-OpenDataPricingUnit.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ function Get-OpenDataPricingUnit
,[PSCustomObject]@{ UnitOfMeasure = '1000 Relay Hours'; AccountTypes = 'EA'; PricingBlockSize = 1000; DistinctUnits = 'Hours'; }
,[PSCustomObject]@{ UnitOfMeasure = '1000 Relay Hrs'; AccountTypes = 'EA'; PricingBlockSize = 1000; DistinctUnits = 'Hours'; }
,[PSCustomObject]@{ UnitOfMeasure = '1000 Renders'; AccountTypes = 'EA'; PricingBlockSize = 1000; DistinctUnits = 'Renders'; }
,[PSCustomObject]@{ UnitOfMeasure = '1000 TB'; AccountTypes = ''; PricingBlockSize = 1000; DistinctUnits = 'TB'; }
,[PSCustomObject]@{ UnitOfMeasure = '1000 Transactions'; AccountTypes = 'EA'; PricingBlockSize = 1000; DistinctUnits = 'Transactions'; }
,[PSCustomObject]@{ UnitOfMeasure = '10000'; AccountTypes = 'EA'; PricingBlockSize = 10000; DistinctUnits = 'Units'; }
,[PSCustomObject]@{ UnitOfMeasure = '10000 '; AccountTypes = 'EA'; PricingBlockSize = 10000; DistinctUnits = 'Units'; }
Expand Down
Loading