Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Default dialog popover styles are lost when trigger button is a TreeLayout Action #33280

Open
2 tasks done
dacs30 opened this issue Nov 15, 2024 · 1 comment
Open
2 tasks done

Comments

@dacs30
Copy link

dacs30 commented Nov 15, 2024

Component

Tree

Package version

^9.0.0

React version

^18

Environment

System:
    OS: Windows 11 10.0.26100
    CPU: (24) x64 AMD Ryzen Threadripper PRO 5945WX 12-Cores
    Memory: 95.00 GB / 127.86 GB
  Browsers:
    Edge: Chromium (129.0.2792.79)
    Internet Explorer: 11.0.26100.1882

Current Behavior

When I have a dialog trigger and popover that are part of a tree action, the styles of the popover are weird when compared to when the dialog logic is out of the actions field. I have recorded a demo showing the bug.

fluent.ui.bug.mp4

Expected Behavior

The default Fluent UI styles should be preserved for the actions

Reproduction

https://stackblitz.com/edit/lbqaha?file=package.json

Steps to reproduce

The code from the stackblitz have a component that isolates the menu and dialog logic. The "..." is the component getting placed outside of the actions menu. The other "..." is the component getting placed in within the TreeLayout actions.

When opening the dialog on both, you will notice that the components within the the actions do not have the default Fluent UI styles getting persisted as they do for the other case.

fluent.ui.bug.mp4

Are you reporting an Accessibility issue?

None

Suggested severity

Low - Has or doesn't need a workaround

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@micahgodbolt
Copy link
Member

This issue may be lower priority as the Nav control seems to fit the users use case better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants