Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: fluent-tag attribute name differs from equivalent React attribute #33281

Open
2 tasks done
vnbaaij opened this issue Nov 15, 2024 · 1 comment
Open
2 tasks done

Comments

@vnbaaij
Copy link
Contributor

vnbaaij commented Nov 15, 2024

Component

Text

Package version

3.0.0-beta.73

@microsoft/fast-element version

2

Environment

Windows

Current Behavior

In the Web Component the fluent-text component has a nowrap attribute with a default value of false. On the React side the same component uses a wrap attribute with a default value of true.

Expected Behavior

I expect both implementations to use the same attribute name and default value. As React is already in production, it probably makes sense to change it on the WC side

Reproduction

https://web-components.fluentui.dev/?path=/docs/components-text--docs

Steps to reproduce

Just look at the storybooks

Are you reporting an Accessibility issue?

None

Suggested severity

High - No workaround

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@chrisdholt
Copy link
Member

In custom elements, an attribute that is predefined as "true" cannot be changed from the view - this is the reason that the attribute name is different. If we kept the name the same, we wouldn't be able to provide the same functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants