Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Not to merge] - PR to deploy charts on pr site till master workflow is enabled #33270

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

[Not to merge] - PR to deploy charts on pr site till master workflow is enabled #33270

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5257c9b
Test only - Enable charts on docsite
AtishayMsft Nov 14, 2024
bf0483e
Update donut chart story
AtishayMsft Nov 14, 2024
d07eb69
Test change
AtishayMsft Nov 16, 2024
64dd25e
Update heap size
AtishayMsft Nov 16, 2024
e82fa64
Revert test change
AtishayMsft Nov 16, 2024
fe92700
Revert docsite change
AtishayMsft Nov 20, 2024
fdb3b5e
Test style change
AtishayMsft Nov 20, 2024
4a44fdc
Add changefile
AtishayMsft Nov 20, 2024
8c12455
Merge branch 'master' into usr/atisjai/chartsDocsite
AtishayMsft Nov 20, 2024
e593b85
test change for docsite
AtishayMsft Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/public-docsite-v9/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"private": true,
Copy link
Collaborator

@fabricteam fabricteam Nov 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Avatar Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.badgeMask.chromium.png 3 Changed
Avatar Converged.Badge Mask RTL.chromium.png 2 Changed

"description": "Fluent UI React v9 documentation",
"scripts": {
"build-storybook": "storybook build -o ./dist/storybook --docs && node ./.storybook/fix-title.js 'Fluent UI React v9' ../dist",
"build-storybook": "cross-env NODE_OPTIONS=--max-old-space-size=8192 storybook build -o ./dist/storybook --docs && node ./.storybook/fix-title.js 'Fluent UI React v9' ../dist",
"clean": "just-scripts clean",
"code-style": "just-scripts code-style",
"just": "just-scripts",
Expand All @@ -22,6 +22,7 @@
},
"dependencies": {
"@fluentui/react-calendar-compat": "*",
"@fluentui/react-charts-preview": "*",
"@fluentui/react-datepicker-compat": "*",
"@fluentui/react-migration-v8-v9": "*",
"@fluentui/react-migration-v0-v9": "*",
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/react-charts-preview/library/src/components/LineChart/LineChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ const _getPointPath = (x: number, y: number, w: number, index: number): string =
L${x - w / 2} ${y + w / 2}
Z`,
//triangle
`M${x - w / 2} ${y - 0.2886 * w}
`M${x - w / 2} ${y - 0.28 * w}
H ${x + w / 2}
L${x} ${y + 0.5774 * w} Z`,
//diamond
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/react-charts-preview/stories/src/DonutChart/DonutChartDefault.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const DonutChartBasic = () => {
legend: 'second',
data: 39000,
color: getColorFromToken(DataVizPalette.color2),
xAxisCalloutData: '2020/04/20',
xAxisCalloutData: '2024/04/20',
},
];

Expand Down
Loading