Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add top:0 to hiddenContentStyles #33289

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add top:0 to hiddenContentStyles #33289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8b7d590
Add top:0 to hiddenContentStyles
smikula Nov 18, 2024
235a77a
Fix
smikula Nov 18, 2024
761c055
Changefile
smikula Nov 18, 2024
9a67894
Test fixes
smikula Nov 18, 2024
db12cd4
More test fixes
smikula Nov 18, 2024
5a143c2
More test fixes
smikula Nov 18, 2024
4121851
Fix
smikula Nov 18, 2024
ca9b4a2
Merge branch 'master' into hidden-styles-fix
smikula Nov 18, 2024
ac81d8b
Fix snapshots
smikula Nov 18, 2024
dd12049
Fix snapshots:
smikula Nov 18, 2024
f054e06
Merge branch 'master' into hidden-styles-fix
smikula Nov 18, 2024
0ea27e4
Merge branch 'hidden-styles-fix' of https://github.com/smikula/fluent…
smikula Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-style-utilities-91276070-927c-4f68-a8d2-70d35e25431d.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Add top:0 to hiddenContentStyle",
"packageName": "@fluentui/style-utilities",
"email": "[email protected]",
"dependentChangeType": "patch"
}
12 changes: 12 additions & 0 deletions ...charting/src/components/HorizontalBarChart/__snapshots__/HorizontalBarChart.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ exports[`HorizontalBarChart - mouse events Should render callout correctly on mo
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -246,6 +247,7 @@ exports[`HorizontalBarChart - mouse events Should render callout correctly on mo
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -596,6 +598,7 @@ exports[`HorizontalBarChart - mouse events Should render customized callout on m
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -761,6 +764,7 @@ exports[`HorizontalBarChart - mouse events Should render customized callout on m
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -1022,6 +1026,7 @@ exports[`HorizontalBarChart snapShot testing Should not render bar labels in abs
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -1154,6 +1159,7 @@ exports[`HorizontalBarChart snapShot testing Should not render bar labels in abs
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -1303,6 +1309,7 @@ exports[`HorizontalBarChart snapShot testing Should render absolute-scale varian
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -1453,6 +1460,7 @@ exports[`HorizontalBarChart snapShot testing Should render absolute-scale varian
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -1620,6 +1628,7 @@ exports[`HorizontalBarChart snapShot testing Should render gradients on bars 1`]
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -1808,6 +1817,7 @@ exports[`HorizontalBarChart snapShot testing Should render gradients on bars 1`]
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -2013,6 +2023,7 @@ exports[`HorizontalBarChart snapShot testing Should render rounded corners on ba
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -2173,6 +2184,7 @@ exports[`HorizontalBarChart snapShot testing Should render rounded corners on ba
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down
30 changes: 15 additions & 15 deletions ...rting/src/components/HorizontalBarChart/__snapshots__/HorizontalBarChartRTL.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ exports[`Horizontal bar chart - Screen resolution Should remain unchanged on zoo
<div
hidden=""
id="tooltip9"
style="position: absolute; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
style="position: absolute; top: 0px; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
>
one
</div>
Expand Down Expand Up @@ -200,7 +200,7 @@ exports[`Horizontal bar chart - Screen resolution Should remain unchanged on zoo
<div
hidden=""
id="tooltip12"
style="position: absolute; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
style="position: absolute; top: 0px; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
>
two
</div>
Expand Down Expand Up @@ -336,7 +336,7 @@ exports[`Horizontal bar chart - Screen resolution Should remain unchanged on zoo
<div
hidden=""
id="tooltip15"
style="position: absolute; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
style="position: absolute; top: 0px; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
>
three
</div>
Expand Down Expand Up @@ -490,7 +490,7 @@ exports[`Horizontal bar chart - Screen resolution Should remain unchanged on zoo
<div
hidden=""
id="tooltip9"
style="position: absolute; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
style="position: absolute; top: 0px; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
>
one
</div>
Expand Down Expand Up @@ -626,7 +626,7 @@ exports[`Horizontal bar chart - Screen resolution Should remain unchanged on zoo
<div
hidden=""
id="tooltip12"
style="position: absolute; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
style="position: absolute; top: 0px; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
>
two
</div>
Expand Down Expand Up @@ -762,7 +762,7 @@ exports[`Horizontal bar chart - Screen resolution Should remain unchanged on zoo
<div
hidden=""
id="tooltip15"
style="position: absolute; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
style="position: absolute; top: 0px; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
>
three
</div>
Expand Down Expand Up @@ -929,7 +929,7 @@ exports[`Horizontal bar chart - Theme Should reflect theme change 1`] = `
<div
hidden=""
id="tooltip12"
style="position: absolute; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
style="position: absolute; top: 0px; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
>
one
</div>
Expand Down Expand Up @@ -1065,7 +1065,7 @@ exports[`Horizontal bar chart - Theme Should reflect theme change 1`] = `
<div
hidden=""
id="tooltip15"
style="position: absolute; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
style="position: absolute; top: 0px; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
>
two
</div>
Expand Down Expand Up @@ -1201,7 +1201,7 @@ exports[`Horizontal bar chart - Theme Should reflect theme change 1`] = `
<div
hidden=""
id="tooltip18"
style="position: absolute; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
style="position: absolute; top: 0px; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
>
three
</div>
Expand Down Expand Up @@ -1368,7 +1368,7 @@ exports[`Horizontal bar chart re-rendering Should re-render the Horizontal bar c
<div
hidden=""
id="tooltip9"
style="position: absolute; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
style="position: absolute; top: 0px; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
>
one
</div>
Expand Down Expand Up @@ -1504,7 +1504,7 @@ exports[`Horizontal bar chart re-rendering Should re-render the Horizontal bar c
<div
hidden=""
id="tooltip12"
style="position: absolute; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
style="position: absolute; top: 0px; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
>
two
</div>
Expand Down Expand Up @@ -1640,7 +1640,7 @@ exports[`Horizontal bar chart re-rendering Should re-render the Horizontal bar c
<div
hidden=""
id="tooltip15"
style="position: absolute; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
style="position: absolute; top: 0px; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
>
three
</div>
Expand Down Expand Up @@ -1794,7 +1794,7 @@ exports[`Horizontal bar chart rendering Should render the Horizontal bar chart l
<div
hidden=""
id="tooltip9"
style="position: absolute; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
style="position: absolute; top: 0px; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
>
one
</div>
Expand Down Expand Up @@ -1930,7 +1930,7 @@ exports[`Horizontal bar chart rendering Should render the Horizontal bar chart l
<div
hidden=""
id="tooltip12"
style="position: absolute; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
style="position: absolute; top: 0px; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
>
two
</div>
Expand Down Expand Up @@ -2066,7 +2066,7 @@ exports[`Horizontal bar chart rendering Should render the Horizontal bar chart l
<div
hidden=""
id="tooltip15"
style="position: absolute; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
style="position: absolute; top: 0px; width: 1px; height: 1px; margin: -1px; padding: 0px; border: 0px; overflow: hidden; white-space: nowrap;"
>
three
</div>
Expand Down
18 changes: 18 additions & 0 deletions ...-charting/src/components/StackedBarChart/__snapshots__/MultiStackedBarChart.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ exports[`MultiStackedBarChart - mouse events Should render callout correctly on
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -299,6 +300,7 @@ exports[`MultiStackedBarChart - mouse events Should render callout correctly on
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -770,6 +772,7 @@ exports[`MultiStackedBarChart - mouse events Should render customized callout on
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -979,6 +982,7 @@ exports[`MultiStackedBarChart - mouse events Should render customized callout on
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -1359,6 +1363,7 @@ exports[`MultiStackedBarChart snapShot testing Should not render bar labels in a
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -1537,6 +1542,7 @@ exports[`MultiStackedBarChart snapShot testing Should not render bar labels in a
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -1809,6 +1815,7 @@ exports[`MultiStackedBarChart snapShot testing Should render absolute-scale vari
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -2005,6 +2012,7 @@ exports[`MultiStackedBarChart snapShot testing Should render absolute-scale vari
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -2295,6 +2303,7 @@ exports[`MultiStackedBarChart snapShot testing renders MultiStackedBarChart corr
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -2499,6 +2508,7 @@ exports[`MultiStackedBarChart snapShot testing renders MultiStackedBarChart corr
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -2797,6 +2807,7 @@ exports[`MultiStackedBarChart snapShot testing renders hideDenominator correctly
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -2991,6 +3002,7 @@ exports[`MultiStackedBarChart snapShot testing renders hideDenominator correctly
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -3279,6 +3291,7 @@ exports[`MultiStackedBarChart snapShot testing renders hideLegend correctly 1`]
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -3483,6 +3496,7 @@ exports[`MultiStackedBarChart snapShot testing renders hideLegend correctly 1`]
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -3709,6 +3723,7 @@ exports[`MultiStackedBarChart snapShot testing renders hideRatio correctly 1`] =
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -3887,6 +3902,7 @@ exports[`MultiStackedBarChart snapShot testing renders hideRatio correctly 1`] =
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -4394,6 +4410,7 @@ exports[`MultiStackedBarChart snapShot testing renders hideTooltip correctly 1`]
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down Expand Up @@ -4598,6 +4615,7 @@ exports[`MultiStackedBarChart snapShot testing renders hideTooltip correctly 1`]
"overflow": "hidden",
"padding": 0,
"position": "absolute",
"top": 0,
"whiteSpace": "nowrap",
"width": 1,
}
Expand Down
Loading
Loading