Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Check for missing translations #5604

Merged
merged 14 commits into from
Nov 28, 2024
Merged

Conversation

thewahome
Copy link
Contributor

@thewahome thewahome commented Oct 15, 2024

Overview

It's easy to forget to update the translation files after a feature is done. It would help us to add a new check to show us the missing translations available

Closes #5607

Notes

Introduces a script file that checks the missing translations and generates readable text for the items

Demo

Language File Untranslated Strings
bundle.l10n.ar.json (12 found)
  • Generation completed successfully.
  • Migration failed: ${error}
  • Name
  • Open File
  • Plugin ${this._clientKey} re-generated successfully.
  • Plugin generated successfully.
  • The kiota version for {0} '{1}' will be changed from {2} to {3}, update your dependencies
  • The kiota version for all clients and plugins will be changed to {0}, update your dependencies
  • Type
  • Version
  • When regenerating, all changes made manually to the generated files will be overridden.
  • You can now select the required endpoints from {0}

@thewahome thewahome requested a review from a team as a code owner October 15, 2024 10:22
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea!

.github/workflows/check-translations.yml Outdated Show resolved Hide resolved
baywet
baywet previously approved these changes Oct 15, 2024
musale
musale previously approved these changes Oct 15, 2024
Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really good check.

@musale
Copy link
Contributor

musale commented Oct 15, 2024

@thewahome quick spot check. The generated artifact shows this output and I believe it's a false positive? The strings are present in the I10n folder files for the languages. Also, there's some duplication on strings like OK, a single return is more clearer?
image

@thewahome
Copy link
Contributor Author

Thanks @musale and @baywet for taking the time to look at it.

I hadn't appropriately marked this as a draft. And it's currently in POC. Your input is greatly appreciated as it will go along way in making sure that the work is complete.

I am also going to add an issue so that this work is triaged and tracked.

fey101
fey101 previously approved these changes Oct 15, 2024
@thewahome thewahome dismissed stale reviews from fey101, musale, and baywet via 2cbfb15 October 16, 2024 06:49
Copy link

sonarcloud bot commented Oct 31, 2024

@baywet baywet merged commit 6746032 into main Nov 28, 2024
213 checks passed
@baywet baywet deleted the task/extension/check-translations branch November 28, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✔️
Development

Successfully merging this pull request may close these issues.

Check for missing translations
5 participants