Avoid using deprecated 'apt-key add' on Debian 12 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check which version of Debian the script is run as and place the key in /usr/share/keyrings, as per the official recommendation.
foop-sec
force-pushed
the
apt-key_deprecation_fix
branch
from
c88f2e4 to
0aa2b63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official Debian Wiki[1] and the man page for apt-key[2] both mark the addition of signing keys via the
apt-key addmechanism as deprecated.One of the suggested alternatives is to place the key in the
/usr/share/keyringsfolder. This not only avoids using a deprecated feature, it also fixes a bug that will occur if the script is run as-is on Debian 12.The bug happens, because the
signed-byfield in theprod.listfile[3] references the signing key as followssigned-by=/usr/share/keyrings/microsoft-prod.gpgThis location is not where the signing key is found, if it is imported by
apt-key add.This causes apt to not find the signing key and thus abort installation.
[1] https://wiki.debian.org/DebianRepository/UseThirdParty
[2] https://manpages.debian.org/bookworm/apt/apt-key.8.en.html
[3] https://packages.microsoft.com/config/debian/12/prod.list