Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: include directions on how to create AzureAIClientProvider using FromConnectionString for AzureAIAgent #10582

Closed
moonbox3 opened this issue Feb 18, 2025 · 1 comment · Fixed by #10616
Closed

.Net: include directions on how to create AzureAIClientProvider using FromConnectionString for AzureAIAgent #10582

moonbox3 opened this issue Feb 18, 2025 · 1 comment · Fixed by #10616
Assignees
@crickman
Labels
agents feature_graduation Applied to all feature graduation issues .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@moonbox3
Copy link
Contributor

The .Net samples on how to use AzureAIAgents seem to obfuscate the required step a dev would use to set up the AzureAIClientProvider:

provider = AzureAIClientProvider.FromConnectionString(TestConfiguration.AzureAI.ConnectionString, new AzureCliCredential());

We should make this more clear either in a README, or call it out in the sample code via comments (or however else you see fit).
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code triage labels Feb 18, 2025
@moonbox3 moonbox3 added agents and removed triage labels Feb 18, 2025
@evchaki evchaki added the sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) label Feb 18, 2025
@crickman
Copy link
Contributor

We've moved away from requiring the client-provider for initializing assistant or azure agents. Going to take a pass to refine the how we create the client...I'll leave this issue open as a place-holder for that.

@crickman crickman mentioned this issue Feb 19, 2025
Merged
4 tasks
@crickman crickman moved this to Sprint: In Review in Semantic Kernel Feb 19, 2025
@crickman crickman added the feature_graduation Applied to all feature graduation issues label Feb 19, 2025
github-merge-queue bot pushed a commit that referenced this issue Feb 20, 2025
@crickman
.Net Agents - Refine client provider/factory (#10616)
82aafd3 
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

Move away from the "client-provider" pattern and make client factory
more discoverable.

Fixes: #10582

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

Expose ability to create an SDK client as a static factory methods on
the agent. This is more discoverable than poking around for the
client-provider and aligns with the Python approach.

- Organized factory code in a separate file from the core agent
abstractions.
- Updated samples

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
@crickman crickman moved this from Sprint: In Review to Sprint: Done in Semantic Kernel Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crickman crickman

Labels
agents feature_graduation Applied to all feature graduation issues .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Status: Sprint: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.Net Agents - Refine client provider/factory microsoft/semantic-kernel
4 participants
@moonbox3 @evchaki @crickman @markwallace-microsoft