Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net MEVD: Consider simplifying Cosmos package names/namespaces #10631

Open
roji opened this issue Feb 20, 2025 · 0 comments
Open

.Net MEVD: Consider simplifying Cosmos package names/namespaces #10631

roji opened this issue Feb 20, 2025 · 0 comments
Assignees
Labels
memory connector memory msft.ext.vectordata Related to Microsoft.Extensions.VectorData .NET Issue or Pull requests regarding .NET code

Comments

@roji
Copy link
Member

roji commented Feb 20, 2025

We have two Cosmos connectors with very long names: AzureCosmosDBMongoDB and AzureCosmosDBNoSQL; this forces the user to deal with type names such as AzureCosmosDBMongoDBVectorStoreRecordCollection.

  • The official Cosmos SDK doesn't include Azure in type names (e.g. CosmosClient), and AFAICT packages targeting Cosmos don't include Azure in their namespace or package names (e.g. EF Core's Microsoft.EntityFrameworkCore.Cosmos).
  • The same is true of the DB suffix: although the full marketing product name is CosmosDB, on APIs the DB is omitted; Cosmos seems to be generally sufficient.
  • Similarly, on the Mongo side, the DB suffix is omitted on type names, e.g. the client is just called MongoClient, and not MongoDBClient.

As a result, I propose renaming the packages to Microsoft.SemanticKernel.Connectors.CosmosNoSQL and CosmosMongoDB. Type names within the package can be called e.g. CosmosNoSQLVectorStoreRecordCollection and CosmosMongoVectorStoreRecordCollection (I plan to propose further possible simplifications to the VectorStoreRecordCollection to make this a bit shorter still).

@roji roji added .NET Issue or Pull requests regarding .NET code memory memory connector msft.ext.vectordata Related to Microsoft.Extensions.VectorData labels Feb 20, 2025
@roji roji self-assigned this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
memory connector memory msft.ext.vectordata Related to Microsoft.Extensions.VectorData .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

No branches or pull requests

1 participant