Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc updates for MSTest #43786

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

@Youssef1313 Youssef1313 requested review from IEvangelist and a team as code owners November 27, 2024 13:36
@dotnetrepoman dotnetrepoman bot added this to the November 2024 milestone Nov 27, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Nov 27, 2024
@@ -38,3 +40,7 @@ Environment variables can be used to supply some runtime configuration informati

> [!NOTE]
> Environment variables take precedence over configuration settings in the *testconfig.json* file.
### `TESTINGPLATFORM_UI_LANGUAGE` environment variable
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right doc page for documenting this? @Evangelink

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's correct. You could check how dotnet cli is structuring this part of the doc, maybe there are some nice things to "copy".

Defines the verbosity level when the `--diagnostic` switch is used. The available values are `Trace`, `Debug`, `Information`, `Warning`, `Error`, or `Critical`.
Defines the verbosity level when the `--diagnostic` switch is used. The available values are `Trace`, `Debug`, `Information`, `Warning`, `Error`, or `Critical`.

- **`--exit-on-process-exit`**
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Evangelink I wanted to make sure if we want to document this one, or if it was intentionally missing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, at the moment we mainly use it to ensure that if some other launching process terminates we also terminates. It feels more technical but maybe it's worth mentioning for users.

WDYT @MarcoRossignoli ?

The directory where the test results are going to be placed. If the specified directory doesn't exist, it's created. The default is `TestResults` in the directory that contains the test application.
The directory where the test results are going to be placed. If the specified directory doesn't exist, it's created. The default is `TestResults` in the directory that contains the test application.

- **`--timeout`**
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Evangelink Same here. Do we want to document this? Or was it missing intentionally?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a miss!

@@ -38,3 +40,7 @@ Environment variables can be used to supply some runtime configuration informati

> [!NOTE]
> Environment variables take precedence over configuration settings in the *testconfig.json* file.
### `TESTINGPLATFORM_UI_LANGUAGE` environment variable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's correct. You could check how dotnet cli is structuring this part of the doc, maybe there are some nice things to "copy".

@@ -183,56 +183,72 @@ To run a test project in CI add one step for each test executable that you wish
The list below described only the platform options. To see the specific options brought by each extension, either refer to the extension documentation page or use the `--help` option.

- **`@`**

Specifies a response file (rsp).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it'd be worth to:

  1. have a link to doc about rsp concept (if there is some)
  2. give an inline example

Defines the verbosity level when the `--diagnostic` switch is used. The available values are `Trace`, `Debug`, `Information`, `Warning`, `Error`, or `Critical`.
Defines the verbosity level when the `--diagnostic` switch is used. The available values are `Trace`, `Debug`, `Information`, `Warning`, `Error`, or `Critical`.

- **`--exit-on-process-exit`**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, at the moment we mainly use it to ensure that if some other launching process terminates we also terminates. It feels more technical but maybe it's worth mentioning for users.

WDYT @MarcoRossignoli ?

The directory where the test results are going to be placed. If the specified directory doesn't exist, it's created. The default is `TestResults` in the directory that contains the test application.
The directory where the test results are going to be placed. If the specified directory doesn't exist, it's created. The default is `TestResults` in the directory that contains the test application.

- **`--timeout`**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a miss!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing docs
2 participants