Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The confirmation style is still "Button Click Confirmation" when deleting database from Cosmos DB account even though change the setting "Azure Databases: Confirmation Style" to "Word Entry Confirmation" #2439

Open
v-ruizh opened this issue Nov 20, 2024 · 2 comments
Labels
AT-CTI Created by CTI team

Comments

@v-ruizh
Copy link

v-ruizh commented Nov 20, 2024

OS: Windows 10
Build Version: 20241120.1
Regression: Not a Regression

Repro Steps:

  1. Navigate to settings page -> Change the setting "Azure Databases: Confirmation Style" to "Word Entry Confirmation".
  2. Delete one container or database from a "Cosmos DB for NoSQL" account.
  3. Check whether the confirmation style is "Word Entry Confirmation" or not.

Expect:
The confirmation style is "Word Entry Confirmation", like the one when deleting database from MongoDB cluster.
Image

Actual:
The confirmation style is still "Button Click Confirmation".
Image

More Info:

  1. This setting "Azure Databases: Confirmation Style" just can control the MongoDB cluster.
  2. It would be better to change the setting to "MongoDB Cluster: Confirmation Style" if not plan to fix this issue.
@v-ruizh v-ruizh added the AT-CTI Created by CTI team label Nov 20, 2024
@tnaum-ms
Copy link
Collaborator

@sevoku I guess we'll try to unify here and apply the confirmation style extension-wide?

I added a new function that can display the confirmation dialog based on the settings.

@v-ruizh v-ruizh changed the title The confirmation style is still "Button Click Confirmation" when deleting database from Cosmos DB account even through change the setting "Azure Databases: Confirmation Style" to "Word Entry Confirmation" The confirmation style is still "Button Click Confirmation" when deleting database from Cosmos DB account even though change the setting "Azure Databases: Confirmation Style" to "Word Entry Confirmation" Nov 20, 2024
@sevoku
Copy link
Member

sevoku commented Nov 20, 2024

@tnaum-ms ideally we should have added this everywhere else before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT-CTI Created by CTI team
Projects
None yet
Development

No branches or pull requests

3 participants