Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When settings.json file is opened and shows "unsaved" status, the connection cannot be saved #18435

Open
yadongyaly opened this issue Nov 18, 2024 · 1 comment

Comments

@yadongyaly
Copy link

yadongyaly commented Nov 18, 2024

  • MSSQL Extension Version: 1.26.0
  • VSCode Version: 1.95.3
  • OS Version: windows 11

Steps to Reproduce:

  1. ctrl+p to open settings.json file, make any changes and keep it unsaved
  2. in mssql extension to open a connection to a sql server, the connection cannot be saved.
@Benjin
Copy link
Contributor

Benjin commented Dec 9, 2024

While we can't save a new connection without write-access to the settings.json file, perhaps we can not block completing a connection on the ability to save it? Something to look into.

@Benjin Benjin modified the milestones: December Release 2024, Backlog Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants