Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix context menu / header filter open & close behavior #18456

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Fix context menu / header filter open & close behavior #18456

merged 5 commits into from
Nov 26, 2024

Conversation

cssuh
Copy link
Member

@cssuh cssuh commented Nov 26, 2024

Fixes #18336

Before:
Context menu & header filter could be opened at the same time

After:
Close context menu when we open the header filter & vice versa

@github-actions GitHub Actions
Copy link

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 49.73% 49.86% $${\color{lightgreen} .13\% }$$
VSIX Size 11713 KB 11713 KB $${\color{lightgreen} 0 KB \space (0\%) }$$
Webview Bundle Size 3104 KB 3108 KB $${\color{lightgreen} 4 KB \space (0\%) }$$

@cssuh cssuh merged commit 5a220e2 into main Nov 26, 2024
6 checks passed
@cssuh cssuh deleted the chsuh/menusFix branch November 26, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benjin Benjin Benjin approved these changes

@kburtram kburtram Awaiting requested review from kburtram kburtram is a code owner

@aasimkhan30 aasimkhan30 Awaiting requested review from aasimkhan30 aasimkhan30 is a code owner

@caohai caohai Awaiting requested review from caohai caohai is a code owner

@laurennat laurennat Awaiting requested review from laurennat laurennat is a code owner

@lewis-sanchez lewis-sanchez Awaiting requested review from lewis-sanchez lewis-sanchez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Context menu & header filter menu can be open at the same time
2 participants
@cssuh @Benjin