Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use short description from MDN for better CSS completion details #58391

Closed
octref opened this issue Sep 10, 2018 · 2 comments
Closed

Use short description from MDN for better CSS completion details #58391

octref opened this issue Sep 10, 2018 · 2 comments
Assignees
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling *duplicate Issue identified as a duplicate of another issue(s)

Comments

@octref
Copy link
Contributor

octref commented Sep 10, 2018

MDN team is working on making short description for CSS properties available: mdn/data#261. We could use those to replace the ones we have in our legacy database. We are already doing so for the new CSS properties that our legacy database do not contain. See: https://github.com/Microsoft/vscode-css-languageservice/blob/master/build/mdn/mdn-documentation.js

Similar to using compatibility data from MDN, we'll use the description from MDN too.

One thing that has not been decided is if there should be a link at the end of completion details that point to the relevant MDN article. The motivation is that people might find it useful when they want to "read more" about a specific CSS property. It is also an attribution to MDN as we are using their data.

The concern is some people might find that it adds noise to the completion item.

@octref octref added css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality labels Sep 10, 2018
@octref octref added this to the Backlog milestone Sep 10, 2018
@octref octref self-assigned this Sep 10, 2018
@octref octref changed the title Use short description from MDN Use short description from MDN for better CSS completion details Sep 10, 2018
@octref octref modified the milestones: Backlog, October 2019 Oct 21, 2019
@octref octref added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 21, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 21, 2019

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Oct 21, 2019
@octref
Copy link
Contributor Author

octref commented Oct 21, 2019

Done with microsoft/vscode-css-languageservice#102.

@chrmarti chrmarti removed the feature-request Request for new features or functionality label Oct 29, 2019
@chrmarti chrmarti removed this from the October 2019 milestone Oct 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants