Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Install and Upgrade Workflows #5224

Open
Trenly opened this issue Feb 19, 2025 · 0 comments
Open

Separate Install and Upgrade Workflows #5224

Trenly opened this issue Feb 19, 2025 · 0 comments
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.

Comments

@Trenly
Copy link
Contributor

Trenly commented Feb 19, 2025

Description of the new feature / enhancement

In the codebase, the workflow is InstallOrUpgrade for standard packages, Install for portable packages, and many of the strings are named for InstallOrUpdate

As the application grows more complex, the differences in functionality should be moved into their own workflows / methods. This would allow the logic to be cleaner

Proposed technical implementation details

Create separate Install() and Upgrade() methods, and have InstallOrUpgrade call the correct method
Have separate strings and behaviors based upon install or upgrade
@Trenly Trenly added the Issue-Feature This is a feature request for the Windows Package Manager client. label Feb 19, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage Issue need to be triaged label Feb 19, 2025
@denelon denelon removed the Needs-Triage Issue need to be triaged label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Trenly @denelon