Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1 RC Bug Bash]: Incorrect documentation links in mgc users -h #351

Open
MIchaelMainer opened this issue Sep 27, 2023 · 8 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@MIchaelMainer
Copy link
Contributor

I needed to get information about permissions. Followed the doc links for /users and got the incorrect document for my use case.

image
@calebkiage
Copy link
Collaborator

This is the link in the metadata:

image

Maybe it's a metadata problem.

@calebkiage calebkiage added the bug Something isn't working label Sep 28, 2023
@ddyett
Copy link
Contributor

ddyett commented Oct 4, 2023

let's follow up this one with the metadata team. This likely would be an issue for powershell as well.

@ddyett
Copy link
Contributor

ddyett commented Oct 4, 2023

follow up happening with Tooling Foundations to address metadata.

@irvinesunday
Copy link

irvinesunday commented Nov 6, 2023

From the latest OpenAPI description, the /users endpoint seems to have the correct documentation link:

image

Ref: https://raw.githubusercontent.com/microsoftgraph/msgraph-metadata/master/openapi/v1.0/openapi.yaml

@ddyett
Copy link
Contributor

ddyett commented Nov 8, 2023

@calebkiage please verify with latest build

@calebkiage
Copy link
Collaborator

@irvinesunday, it seems the link has changed to a different one this time. see microsoftgraph/msgraph-metadata v1.0 openapi.yaml

image

@irvinesunday
Copy link

@irvinesunday, it seems the link has changed to a different one this time. see microsoftgraph/msgraph-metadata v1.0 openapi.yaml

image

Thanks for surfacing this @calebkiage

The url changed from https://learn.microsoft.com/en-us/graph/api/user-list?view=graph-rest-1.0 to https://learn.microsoft.com/en-gb/graph/api/intune-onboarding-user-list?view=graph-rest-1.0

@millicentachieng can you help look into API doctor and see what might have changed in the process of scraping descriptions for users?

@millicentachieng
Copy link

millicentachieng commented Jan 15, 2024

There are common endpoints between the regular Graph and Intune, documented separately in different API topics, e.g. /users, /users/{id}, /organization, and /organization/{id}.

While the API Doctor process remains unchanged, Intune has recently introduced additional metadata to their documentation aiming to facilitate code snippets injection through API Doctor. Consequently, API Doctor now extracts descriptions and documentation links from these updated Intune docs. In cases where multiple documentation entries are present for an endpoint, API Doctor selects the first item on the list, which happens to be Intune in this scenario.

We've observed that this has impacted various tools, including the links on Graph Explorer. There's an ongoing discussion about the optimal approach to manage documentation and metadata for shared endpoints. One proposed solution is to merge all API topics that refer to the same endpoint to streamline the information.

Example:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants