Best Practices for Upgrading to Version 21

[dadams39]

There are a lot of changes in the new version that can break the initial sequence of creating a graph client. An example below:

──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
# github.com/microsoftgraph/msgraph-sdk-go/admin/serviceannouncement/healthoverviews/item/issues/item/incidentreport
../../../go/pkg/mod/github.com/microsoftgraph/[email protected]/admin/serviceannouncement/healthoverviews/item/issues/item/incidentreport/incident_report_request_builder.go:54:16: cannot use ... in call to non-variadic requestInfo.AddRequestOptions
../../../go/pkg/mod/github.com/microsoftgraph/[email protected]/admin/serviceannouncement/healthoverviews/item/issues/item/incidentreport/incident_report_request_builder.go:54:16: requestInfo.AddRequestOptions(options.Options...) (no value) used as value
# github.com/microsoftgraph/msgraph-sdk-go/admin/serviceannouncement/issues/item/incidentreport
../../../go/pkg/mod/github.com/microsoftgraph/[email protected]/admin/serviceannouncement/issues/item/incidentreport/incident_report_request_builder.go:54:16: cannot use ... in call to non-variadic requestInfo.AddRequestOptions
../../../go/pkg/mod/github.com/microsoftgraph/[email protected]/admin/serviceannouncement/issues/item/incidentreport/incident_report_request_builder.go:54:16: requestInfo.AddRequestOptions(options.Options...) (no value) used as value
# github.com/microsoftgraph/msgraph-sdk-go/admin/serviceannouncement/messages/favorite
../../../go/pkg/mod/github.com/microsoftgraph/[email protected]/admin/serviceannouncement/messages/favorite/favorite_request_builder.go:57:16: cannot use ... in call to non-variadic requestInfo.AddRequestOptions
../../../go/pkg/mod/github.com/microsoftgraph/[email protected]/admin/serviceannouncement/messages/favorite/favorite_request_builder.go:57:16: requestInfo.AddRequestOptions(options.Options...) (no value) used as value
# github.com/microsoftgraph/msgraph-sdk-go/admin/serviceannouncement/messages/markread
../../../go/pkg/mod/github.com/microsoftgraph/[email protected]/admin/serviceannouncement/messages/markread/mark_read_request_builder.go:57:16: cannot use ... in call to non-variadic requestInfo.AddRequestOptions
../../../go/pkg/mod/github.com/microsoftgraph/[email protected]/admin/serviceannouncement/messages/markread/mark_read_request_builder.go:57:16: requestInfo.AddRequestOptions(options.Options...) (no value) used as value
# github.com/microsoftgraph/msgraph-sdk-go/admin/serviceannouncement/messages/archive
../../../go/pkg/mod/github.com/microsoftgraph/[email protected]/admin/serviceannouncement/messages/archive/archive_request_builder.go:57:16: cannot use ... in call to non-variadic requestInfo.AddRequestOptions...

This list goes on for 15k lines. I was wondering if there is an example of a graph client creation with v21?

[dadams39]

This is the state of my go.mod file:

module github.com/some/repo

go 1.18

require (
        github.com/Azure/azure-sdk-for-go/sdk/azcore v0.23.1
        github.com/Azure/azure-sdk-for-go/sdk/azidentity v0.14.0
        github.com/microsoft/kiota-authentication-azure-go v0.2.1
        github.com/microsoft/kiota-serialization-json-go v0.3.1
        github.com/microsoftgraph/msgraph-sdk-go v0.21.0
        github.com/microsoftgraph/msgraph-sdk-go-core v0.24.0
)

require (
        github.com/Azure/azure-sdk-for-go/sdk/internal v0.9.2 // indirect
        github.com/AzureAD/microsoft-authentication-library-for-go v0.5.0 // indirect
        github.com/cjlapao/common-go v0.0.19 // indirect
        github.com/golang-jwt/jwt v3.2.2+incompatible // indirect
        github.com/google/uuid v1.3.0 // indirect
        github.com/kylelemons/godebug v1.1.0 // indirect
        github.com/microsoft/kiota-abstractions-go v0.5.0 // indirect
        github.com/microsoft/kiota-http-go v0.3.0 // indirect
        github.com/microsoft/kiota-serialization-text-go v0.2.0 // indirect
        github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8 // indirect
        github.com/yosida95/uritemplate/v3 v3.0.2 // indirect
        golang.org/x/crypto v0.0.0-20220427172511-eb4f295cb31f // indirect
        golang.org/x/net v0.0.0-20220425223048-2871e0cb64e4 // indirect
        golang.org/x/sys v0.0.0-20220503163025-988cb79eb6c6 // indirect
        golang.org/x/text v0.3.7 // indirect
)

[baywet]

Why don't you upgrade directly to 0.22.0 which aligns everything?

[dadams39]

That is the answer. For whatever reason, even though I was calling $ go mod -u ./... , the packages were not upgrading.
go: upgraded github.com/microsoftgraph/msgraph-sdk-go v0.21.0 => v0.22.0 manually. Errors are gone.

[dadams39]

I am seeing some strange behavior though.
In messages_request_builder.go, there is a method

type MessagesRequestBuilderGetQueryParameters struct {

However, when I try to call it:

 query := messages.MessagesRequestBuilderGetQueryParameters{
     Select: []string{"body", "sender", "subject"}, 
}

which I would normally send into

options := messages.MessagesRequestBuilderGetOptions

However, that is no longer a function. This fundamentally changes the process to get messages. The documents do not seem to support the changes.

[dadams39]

I have made the changes. Is there somewhere that I would submit as a tutorial?

[baywet]

Are you referring to the fact that MessagesRequestBuilderGetOptions is now MessagesRequestBuilderGetRequestConfiguration?

[dadams39]

That was my reference.

[baywet]

We don't provide upgrade documentation for the minor releases, which arguably makes for a rough upgrade experience. If you want to expand the information available in the changelog please go ahead and submit a PR, I'll then replicate on the release information itself.