-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code blocks break <details> rendering #34
Comments
After playing around with several ideas, I think the best way here is to highlight the error and have the user fix it. Fixing it automatically would mean rewriting the lexer of marked. Instead, I tried https://www.npmjs.com/package/node-libxml and verifying that the XML is well-formed does the job. |
Hello, @mihaeu! How to ReproduceWorksExample 1: <details>
<summary>example 1</summary>
Some text
</details> Example 2 (this works, but doesn't work in Gitlab, Github, VsCode, and thus when publishing via site generators): <details>
<summary>example 2</summary>
```xml
<test />
```
</details> BrokenExample 1: <details>
<summary>example 1</summary>
Some text
</details> Example 2: <details>
<summary>example 2</summary>
Some text
</details> Example 3: <details>
<summary>example 3</summary>
```xml
<test />
```
</details> Example 4: <details>
<summary>example 4</summary>
```xml
<test />
```
</details> Example 5: <details>
<summary>example 5</summary>
```xml
<test />
```
</details> But
<td>
<details><summary>example 6</summary>
```xml
<test />
```
</details>
</td>
<td>
<details><summary>example 6</summary>
```xml
<test />
```
</details>
</td> it looks like this (without dropdown): |
Bug Description
Within a details block, rendering of code blocks seems to be broken. Adding an empty line after the opening block breaks the rendering.
How to Reproduce
Works
Input
Output
Broken
Input
(newline after xml codefences
Output
The text was updated successfully, but these errors were encountered: